Fix NULL handling in multi-batch Parallel Hash Left Join.

macdice · macdice · commit fd6449aa3875 · 2018-11-03T11:08:03.000+13:00
NULL keys in left joins were skipped when building batch files. Repair, by making the keep_nulls argument to ExecHashGetHashValue() depend on whether this is a left outer join, as we do in other paths. Bug #15475. Thinko in 1804284. Back-patch to 11. Reported-by: Paul Schaap Diagnosed-by: Andrew Gierth Dicussion: https://postgr.es/m/15475-11a7a783fed72a36%40postgresql.org
diff --git a/src/backend/executor/nodeHashjoin.c b/src/backend/executor/nodeHashjoin.c
@@ -1395,7 +1395,7 @@ ExecParallelHashJoinPartitionOuter(HashJoinState *hjstate)
 		if (ExecHashGetHashValue(hashtable, econtext,
 								 hjstate->hj_OuterHashKeys,
 								 true,	/* outer tuple */
-								 false, /* outer join, currently unsupported */
+								 HJ_FILL_OUTER(hjstate),
 								 &hashvalue))
 		{
 			int			batchno;

Original file line number	Diff line number	Diff line change
`@@ -1395,7 +1395,7 @@ ExecParallelHashJoinPartitionOuter(HashJoinState *hjstate)`
`1395`	`1395`	`if (ExecHashGetHashValue(hashtable, econtext,`
`1396`	`1396`	`hjstate->hj_OuterHashKeys,`
`1397`	`1397`	`true, /* outer tuple */`
`1398`		`- false, /* outer join, currently unsupported */`
	`1398`	`+ HJ_FILL_OUTER(hjstate),`
`1399`	`1399`	`&hashvalue))`
`1400`	`1400`	`{`
`1401`	`1401`	`int batchno;`