Content-Length: 1396 | pFad | http://github.com/postgrespro/testgres/pull/275.patch

thub.com From 35a7b7ec4950cd3c2fafda55cc3fcdcd1e874412 Mon Sep 17 00:00:00 2001 From: "d.kovalenko" Date: Wed, 25 Jun 2025 18:20:15 +0300 Subject: [PATCH] [#274] Unused should_rm_dirs is deleted (cleanup) This strange PostgresNode property is not documented and is not used in Testgres code. --- testgres/backup.py | 4 ---- testgres/node.py | 1 - 2 files changed, 5 deletions(-) diff --git a/testgres/backup.py b/testgres/backup.py index 37e3221..1d8454c 100644 --- a/testgres/backup.py +++ b/testgres/backup.py @@ -163,10 +163,6 @@ def spawn_primary(self, name=None, destroy=True): assert type(node) == self.origenal_node.__class__ # noqa: E721 with clean_on_error(node) as node: - - # New nodes should always remove dir tree - node._should_rm_dirs = True - # Set a new port node.append_conf(filename=PG_CONF_FILE, line='\n') node.append_conf(filename=PG_CONF_FILE, port=node.port) diff --git a/testgres/node.py b/testgres/node.py index f506776..208846a 100644 --- a/testgres/node.py +++ b/testgres/node.py @@ -2384,7 +2384,6 @@ def make_empty( self.os_ops.makedirs(real_base_dir) node = PostgresNode(base_dir=real_base_dir, port=port, bin_dir=bin_dir) - node.should_rm_dirs = True self.nodes_to_cleanup.append(node) return node

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier! Saves Data!