Content-Length: 236998 | pFad | http://github.com/python/python-docs-theme/issues/119

76 Dark theme: Safari: styling of version switcher in narrow window · Issue #119 · python/python-docs-theme · GitHub
Skip to content

Dark theme: Safari: styling of version switcher in narrow window #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
m-aciek opened this issue Mar 18, 2023 · 2 comments
Open

Dark theme: Safari: styling of version switcher in narrow window #119

m-aciek opened this issue Mar 18, 2023 · 2 comments
Labels
good first issue Good for newcomers help wanted

Comments

@m-aciek
Copy link
Contributor

m-aciek commented Mar 18, 2023 •
edited
Loading

I am not sure even if it's worth fixing, but just wanted to drop the note, that on Safari 16.3 (18614.4.6.1.6) selector for version is not being styled as "quick search" box. It used to be of the same style before the update (#44).

Zrzut ekranu 2023-03-18 o 23 40 46

3.11:
Zrzut ekranu 2023-03-18 o 23 58 23

cc @septatrix
@septatrix
Copy link
Contributor

Sadly I do not have access to a Safari browser and cannot reproduce this on Chrome or Firefox. I see that the wrapping element span.version_switcher_placeholder was previously a div and that it previously had appearance: none; set which was cumbersome with the dark styles because it requires many more manual overrides. If with Safari someone wants to investigate, this might be some starting points.

@hugovk
Copy link
Member

hugovk commented Mar 25, 2023

I can reproduce (Safari 16.3/macOS Ventura 13.2.1), but also note they're the same for wider window:

image

image

It would be nice to fix this, and have them consistent like this for both layouts (and possibly the theme and language selectors too):

image

But I don't think this is a showstopper to go live with the dark theme.

@hugovk hugovk added help wanted good first issue Good for newcomers labels Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hugovk @m-aciek @septatrix








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/python/python-docs-theme/issues/119

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy