Content-Length: 416171 | pFad | http://github.com/typescript-eslint/typescript-eslint/pull/11355/#top

D9 fix(typescript-estree): if the template literal is tagged and the text has an invalid escape, `cooked` will be `null` by nayounsang · Pull Request #11355 · typescript-eslint/typescript-eslint · GitHub
Skip to content

fix(typescript-estree): if the template literal is tagged and the text has an invalid escape, cooked will be null #11355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
Draft

fix(typescript-estree): if the template literal is tagged and the text has an invalid escape, cooked will be null #11355

wants to merge 19 commits into from
+224 −42

Conversation

nayounsang
Copy link
Contributor

@nayounsang nayounsang commented Jun 28, 2025 •
edited
Loading

PR Checklist

Overview

ref: https://github.com/estree/estree/blob/2bc9ea235184b6164e31b1088575447657e686c6/es2018.md?plain=1#L34

  • Add a flag isInTaggedTemplate indicating whether template literal is tagged
  • Function to validate escape
  • Add test case

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @nayounsang!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jun 28, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 888e312
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/6880a667d5860a0008e04e88
😎 Deploy Preview https://deploy-preview-11355--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nayounsang nayounsang marked this pull request as draft June 28, 2025 08:59
@nayounsang nayounsang changed the title fix(typescript-estree): If the template literal is tagged and the text has an invalid escape, cooked will be null fix(typescript-estree): if the template literal is tagged and the text has an invalid escape, cooked will be null Jun 28, 2025
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 28, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 888e312

Command Status Duration Result
nx run-many -t lint ❌ Failed 3m 13s View ↗
nx run integration-tests:test ❌ Failed 52s View ↗
nx test eslint-plugin-internal --coverage=false ❌ Failed 9s View ↗
nx test ast-spec ❌ Failed 11s View ↗
nx test eslint-plugin-internal ❌ Failed 10s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 10s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx run types:build ✅ Succeeded 2s View ↗
Additional runs (4) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-07-23 09:13:37 UTC

@nayounsang
Copy link
Contributor Author

nayounsang commented Jun 28, 2025 •
edited
Loading

It's strange. In my local, I cleared the cache and the changed types were built in the types package. Isn't the CI environment a new virtual machine that runs anyway?

typescript-estree has a dependency on types. TemplateElement comes from types
TemplateElement in types is auto-generated by ast-spec.
In nx cloud, types is hitting cache in CI.
So, changes are not updated and an error occurs.
Do I need to do something separate?

@nayounsang
Copy link
Contributor Author

nayounsang commented Jul 20, 2025 •
edited
Loading

hi @JamesHenry
Thank you for your efforts on this difficult problem.

  • Can I continue working on this PR?
  • Is it okay if I merge with the main branch and resolve conflicts freely?
  • If CI-related work is not completed, can I help?

@JamesHenry
Copy link
Member

@nayounsang Yes, sorry I forgot about this one, I obviously kept iterating on your other one to discover that one wasn't a caching issue. This one might be related to your other one or it might be totally separate.

Please revert my changes when you fix up the conflicts and let's get back to a clean slate. If it's still failing unexpectedly after that I can take another look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Wrong cooked value of TemplateElement in TaggedTemplateExpression
2 participants
@nayounsang @JamesHenry








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/typescript-eslint/typescript-eslint/pull/11355/#top

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy