Content-Length: 303812 | pFad | https://github.com/brave/brave-browser/issues/38708

22 Move Sidebar up to the top level in the application menu · Issue #38708 · brave/brave-browser · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Sidebar up to the top level in the application menu #38708

Closed
1 of 6 tasks
rebron opened this issue May 30, 2024 · 3 comments · Fixed by brave/brave-core#24121
Closed
1 of 6 tasks

Move Sidebar up to the top level in the application menu #38708

rebron opened this issue May 30, 2024 · 3 comments · Fixed by brave/brave-core#24121
Assignees
@sangwoo108
Labels
feature/sidebar Relating to Brave's Sidebar feature feature/user-interface All UI related OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA Pass-macOS-arm64 QA/Yes release-notes/include
Milestone
1.69.x - Release

Comments

@rebron
Copy link
Collaborator

rebron commented May 30, 2024 •
edited
Loading

Description

Currently sidebar is buried in the application/hamburger menu in More tools.... Sidebar visibility should be at the top level. On | Autohide | Off should correspond to Always | On mouse over | Never sub menu items.

Steps to reproduce

  1. Open application menu.
  2. Notice sidebar is another level deep under More tools...

Actual result

Screenshot 2024-05-30 at 1 27 10 PM

Expected result

Screenshot 2024-05-30 at 1 29 19 PM Screenshot 2024-06-06 at 9 01 53 AM Screenshot 2024-06-06 at 9 01 46 AM

Figma file: https://www.figma.com/design/H11ZOl6JMYbCTW4ZJXqR5V/%F0%9F%A6%81-Browser?node-id=229-18698&t=L2JqSDrMOKAtOFrc-0

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.68.x and higher.

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response
@rebron rebron changed the title Move Sidebar up the top level in application/hamburger menu Move Sidebar up to the top level in application/hamburger menu May 30, 2024
@rebron rebron added feature/sidebar Relating to Brave's Sidebar feature polish Nice to have — usually related to front-end/visual tasks QA/Yes release-notes/include labels May 30, 2024
@aguscruiz
Copy link

Design file here:
https://www.figma.com/design/H11ZOl6JMYbCTW4ZJXqR5V/%F0%9F%A6%81-Browser?node-id=6697-27337&t=LVdwfrGMPFimqU0t-1

@rebron ready

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jun 3, 2024
@rebron rebron assigned simonhong and unassigned rebron and aguscruiz Jun 3, 2024
@rebron rebron changed the title Move Sidebar up to the top level in application/hamburger menu Move Sidebar up to the top level in the application menu Jun 6, 2024
@sangwoo108 sangwoo108 self-assigned this Jun 11, 2024
@sangwoo108 sangwoo108 mentioned this issue Jun 11, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.69.x - Nightly milestone Jun 12, 2024
@stephendonner stephendonner added the feature/user-interface All UI related label Jun 28, 2024
@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jul 11, 2024
@LaurenWags
Copy link
Member

LaurenWags commented Jul 11, 2024 •
edited
Loading

Verified with

Brave	1.69.98 Chromium: 127.0.6533.26 (Official Build) nightly (arm64) 
Revision	a7710883b2316472175f7b756e561cca3f02b254
OS	macOS Version 14.6 (Build 23G5061b)

Verified test plan from brave/brave-core#24121 (comment) and STR from #38708 (comment).

Confirmed the "Sidebar" show option is at the top level of the app/hamburger menu, right below VPN
Confirmed the "Sidebar" show option is not displayed under "More Tools" on app/hamburger menu
Confirmed On | Autohide | Off correspond to Always | On mouse over | Never options from settings
Confirmed selecting On | Autohide | Off is persisted across new windows and browser restarts
Confirmed expected color of selection for both dark and light themes

Light Dark
lt dk

@LaurenWags LaurenWags added QA Pass-macOS-arm64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jul 12, 2024
@stephendonner
Copy link

Verified PASSED using

Brave | 1.69.137 Chromium: 127.0.6533.100 (Official Build) beta (x86_64)
-- | --
Revision | 40b6ccbd1eb76c8f575e83de8ad81c4349d3f32a
OS | macOS Version 11.7.10 (Build 20G1427)

Verified test plan from brave/brave-core#24121 (comment) and STR from #38708 (comment).

Confirmed the "Sidebar" show option is at the top level of the app/hamburger menu, right below VPN
Confirmed the "Sidebar" show option is not displayed under "More Tools" on app/hamburger menu
Confirmed On | Autohide | Off correspond to Always | On mouse over | Never options from settings
Confirmed selecting On | Autohide | Off is persisted across new windows and browser restarts
Confirmed expected color of selection for both dark and light themes

Light Dark
Screen Shot 2024-08-08 at 12 06 07 PM Screen Shot 2024-08-08 at 12 06 26 PM

@LaurenWags LaurenWags mentioned this issue Aug 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangwoo108 sangwoo108

Labels
feature/sidebar Relating to Brave's Sidebar feature feature/user-interface All UI related OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA Pass-macOS-arm64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.69.x - Release
Development

Successfully merging a pull request may close this issue.

Move Sidebar menu to the top level brave/brave-core
7 participants
@stephendonner @sangwoo108 @rebron @simonhong @aguscruiz @LaurenWags @brave-builds








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/brave/brave-browser/issues/38708

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy