Content-Length: 268260 | pFad | https://github.com/brave/brave-browser/issues/38898

AD Deleting browsing data dialog is too small · Issue #38898 · brave/brave-browser · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting browsing data dialog is too small #38898

Closed
3 of 6 tasks
fmarier opened this issue Jun 7, 2024 · 2 comments · Fixed by brave/brave-core#24095
Closed
3 of 6 tasks

Deleting browsing data dialog is too small #38898

fmarier opened this issue Jun 7, 2024 · 2 comments · Fixed by brave/brave-core#24095
Assignees
@mkarolin
Labels
feature/settings OS/Desktop priority/P4 Planned work. We expect to get to it "soon". privacy QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.69.x - Release

Comments

@fmarier
Copy link
Member

fmarier commented Jun 7, 2024

Description

The "Delete browsing data" dialog box is too small and currently obscures the "Reset Brave Rewards data" link. This probably happened when the notice about search history was added in Chromium. It does however make it look like we are intentionally hiding this option behind a scrollbar.

Steps to reproduce

  1. Open brave://settings/clearBrowserData

Actual result

Screenshot from 2024-06-07 11-30-51
Screenshot from 2024-06-07 11-31-00

Expected result

The scroll bar should not be present and the dialog box should be big enough to fit the extra link we add:
Screenshot from 2024-06-07 11-34-55

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave	1.67.105 Chromium: 126.0.6478.26 (Official Build) beta (64-bit) 
Revision	ff15eaa0be4f63abc388184895a7450c929375c8
OS	Linux

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response
@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/include labels Jun 7, 2024
@mkarolin mkarolin mentioned this issue Jun 10, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.69.x - Nightly milestone Jun 11, 2024
@stephendonner
Copy link

stephendonner commented Jul 2, 2024 •
edited
Loading

Verified PASSED using

Brave | 1.69.73 Chromium: 127.0.6533.26 (Official Build) nightly (64-bit)
-- | --
Revision | ebfe046ab1178f2195d83704420ed1ffa0370804
OS | Windows 10 Version 22H2 (Build 19045.4598)

Steps:

  1. installed 1.69.73
  2. launched Brave
  3. opened brave://settings/clearBrowserData

Compared dialogs, and confirmed Your search engine is Brave displays without need for a scrollbar

1.67.123 1.69.73
image image

@MadhaviSeelam
Copy link

MadhaviSeelam commented Jul 23, 2024 •
edited
Loading

Verification PASSED using

Brave | 1.69.122 Chromium: 127.0.6533.57 (Official Build) beta (64-bit)
-- | --
Revision | bd77e9b76a8e67ff2bf9f62f1df7d60378ca811f
OS | Windows 11 Version 23H2 (Build 22631.3880)
  1. installed 1.69.122
  2. launched Brave
  3. opened brave://settings/clearBrowserData

Compared dialogs, and confirmed "Your search engine is Brave...." displays without need for a scrollbar for Basic tab

1.67.134 1.69.122
image image

For Advanced and On exit, scrollbar is shown as expected

Advanced On exit
image image
image image

@LaurenWags LaurenWags mentioned this issue Aug 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
feature/settings OS/Desktop priority/P4 Planned work. We expect to get to it "soon". privacy QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.69.x - Release
Development

Successfully merging a pull request may close this issue.

Makes clear browsing data dialog taller. brave/brave-core
6 participants
@fmarier @stephendonner @rebron @mkarolin @brave-builds @MadhaviSeelam








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/brave/brave-browser/issues/38898

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy