Content-Length: 271528 | pFad | https://github.com/brave/brave-browser/issues/39231

A4 [iOS] - Add Leo busy view and Leo session refresh view · Issue #39231 · brave/brave-browser · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] - Add Leo busy view and Leo session refresh view #39231

Closed
3 of 5 tasks
Brandon-T opened this issue Jun 21, 2024 · 2 comments · Fixed by brave/brave-core#24325
Closed
3 of 5 tasks

[iOS] - Add Leo busy view and Leo session refresh view #39231

Brandon-T opened this issue Jun 21, 2024 · 2 comments · Fixed by brave/brave-core#24325
Assignees
@Brandon-T
Labels
browser-ai OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.68.x - Release

Comments

@Brandon-T
Copy link

Description

  • iOS is missing the Session Refresh View and Busy View

Steps to reproduce

  1. Become Leo Premium (either via AppStore or via Linking)
  2. Get rate limited or session expired (can take a few days)

Actual result

  • Shows Premium upgrade prompt instead

Expected result

  • Should show Leo busy when rate-limited (activeDisconnected) via AppStore
  • Should show Refresh session when rate-limited (activeDisconnected) via Linking from Desktop

Reproduces how often

Easily reproduced

Brave version

1.65.x+

Device/iOS version

iPhone/iPad

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response
@Brandon-T Brandon-T added QA/Yes release-notes/include OS/iOS Fixes related to iOS browser functionality labels Jun 21, 2024
@Brandon-T Brandon-T self-assigned this Jun 21, 2024
@Brandon-T Brandon-T mentioned this issue Jun 21, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.69.x - Nightly milestone Jun 25, 2024
@brave-builds brave-builds mentioned this issue Jun 25, 2024
Merged
7 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Jul 9, 2024

The above requires 1.68.116 or higher for 1.68.x verification 👍

@hffvld hffvld mentioned this issue Aug 2, 2024
Open
5 tasks
@hffvld
Copy link
Contributor

hffvld commented Aug 2, 2024 •
edited
Loading

Verified on iPhone 14 and iPad Air using version(s):

Device/OS: 
- iPhone 14 / iOS 17.6
- iPad Air / iPadOS 16.7.2
Brave build: 1.68 (134)
BraveCore: 1.68.134 (127.0.6533.88)

Filed follow-up issue #40250

IAP - Leo busy when rate-limited

STEPS:

  1. Launch Brave
  2. Settings > Leo > Go Premium
  3. Purchase Leo subscription
  4. Open Leo UI > Confirm that Premium subscription is active
  5. Wait ~2 - 3 days > Open Leo > Verify Leo busy prompt must be shown

ACTUAL RESULTS:

  • Verify that the Leo busy prompt must be shown when rate-limited (activeDisconnected) via IAP.
  • Observed that the Upgrade to Premium prompt is shown instead of the expected prompt.
1 2
1 2
Linked from Desktop - Refresh session when rate-limited

STEPS:

  1. Purchase Leo premium subscription on Desktop
  2. Launch Brave on iOS
  3. Go to Settings > Leo > Go premium > Refresh your credentials
  4. Link active subscription to iOS device
  5. Open Leo > Confirm that Premium subscription is active
  6. Wait ~2 - 3 days > Open Leo > Verify Refresh session prompt must be shown

ACTUAL RESULTS:

  • Verify that the Refresh session prompt must be shown when rate-limited (activeDisconnected) via Linking from Desktop.
  • Observed that the Upgrade to Premium prompt is shown instead of the expected prompt.
1 2
1 2

@Uni-verse Uni-verse mentioned this issue Sep 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Brandon-T Brandon-T

Labels
browser-ai OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone QA/Yes release-notes/include
Projects
Browser AI
Status: Done
Milestone
1.68.x - Release
Development

Successfully merging a pull request may close this issue.

[iOS] - Added Error Views for Premium Disconnected brave/brave-core
4 participants
@Brandon-T @kjozwiak @brave-builds @hffvld








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/brave/brave-browser/issues/39231

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy