Content-Length: 298368 | pFad | https://github.com/brave/brave-browser/issues/39376

58 Side panel open/close animation doesn't work in some condition · Issue #39376 · brave/brave-browser · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Side panel open/close animation doesn't work in some condition #39376

Closed
3 of 6 tasks
simonhong opened this issue Jun 26, 2024 · 4 comments · Fixed by brave/brave-core#24382
Closed
3 of 6 tasks

Side panel open/close animation doesn't work in some condition #39376

simonhong opened this issue Jun 26, 2024 · 4 comments · Fixed by brave/brave-core#24382
Assignees
@simonhong
Labels
bug feature/sidebar Relating to Brave's Sidebar feature OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.69.x - Release

Comments

@simonhong
Copy link
Member

simonhong commented Jun 26, 2024 •
edited
Loading

Description

Side panel open/close animation doesn't work when Show sidebar option is Always
With On mouseover or Never, we can see panel animation

Steps to reproduce

  1. Set Always for Show sidebar option
  2. Click sidebar toolbar button
  3. Check sidebar opens/closes with animation

Actual result

No animation

Screen.Recording.2024-06-26.144453.mp4

Expected result

With animation

Screen.Recording.2024-06-26.161148.mp4

Reproduces how often

Easily reproduced

Brave version (brave://version info)

All version.

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

cc @rebron @brave/qa-team
@simonhong simonhong self-assigned this Jun 26, 2024
@simonhong
Copy link
Member Author

checking now.

@simonhong simonhong mentioned this issue Jun 26, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.69.x - Nightly milestone Jul 1, 2024
@stephendonner
Copy link

stephendonner commented Jul 10, 2024 •
edited
Loading

Verified PASSED using

Brave | 1.69.95 Chromium: 127.0.6533.26 (Official Build) nightly (64-bit)
-- | --
Revision | ef586bb495b8e8353315768cbc905b14079fbf0f
OS | Windows 10 Version 22H2 (Build 19045.4651)

First, confirmed the issue using

1.68.115 Chromium: 127.0.6533.26 (Official Build) beta (64-bit)

Steps:

  1. installed 1.69.95
  2. launched Brave
  3. confirmed default setting of Sidebar -> On
  4. clicked on the Show sidebar
  5. confirmed sidebar was shown (defaulting to Leo), with a sliding animation
  6. clicked on Hide sidebar
  7. confirmed sidebar was hidden, with a sliding animation
2024-07-10_14h47_28.mp4

@MadhaviSeelam
Copy link

MadhaviSeelam commented Jul 30, 2024 •
edited
Loading

Verification PASSED using

Brave	1.69.128 Chromium: 127.0.6533.73 (Official Build) beta (64-bit) 
Revision	715445841b1da480bcc24c12077a6dc926951996
OS	Linux

Reproduced the issue in 1.68.128 Chromium: 127.0.6533.73

Steps:

  1. installed 1.69.128
  2. launched Brave
  3. confirmed default setting of Sidebar -> On
  4. clicked on the Show sidebar
  5. confirmed sidebar was shown (defaulting to Leo), with a sliding animation
  6. clicked on Hide sidebar
  7. confirmed sidebar was hidden, with a sliding animation
  8. verified when sidebar was on mouseover mode, sliding animation is shown as expected
2024-07-29_16h53_08.mp4

@stephendonner
Copy link

Verified PASSED using

Brave | 1.69.129 Chromium: 127.0.6533.73 (Official Build) beta (x86_64)
-- | --
Revision | 0ab2f25cd017b563fd72d68048f809659a351a04
OS | macOS Version 11.7.10 (Build 20G1427)

Steps:

  1. installed 1.69.129
  2. launched Brave
  3. confirmed default setting of Sidebar -> On
  4. clicked on the Show sidebar
  5. confirmed sidebar was shown (defaulting to Leo), with a sliding animation
  6. clicked on Hide sidebar
  7. confirmed sidebar was hidden, with a sliding animation
  8. verified when sidebar was on mouseover mode, sliding animation is shown as expected

sidebar-open

@LaurenWags LaurenWags mentioned this issue Aug 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
bug feature/sidebar Relating to Brave's Sidebar feature OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.69.x - Release
Development

Successfully merging a pull request may close this issue.

Fixed show/hide animation is not used for side panel toggling brave/brave-core
5 participants
@stephendonner @simonhong @LaurenWags @brave-builds @MadhaviSeelam








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/brave/brave-browser/issues/39376

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy