Content-Length: 247132 | pFad | https://github.com/brave/brave-browser/issues/39513

E1 Add Refresh Quote Button to Swap and Bridge · Issue #39513 · brave/brave-browser · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Refresh Quote Button to Swap and Bridge #39513

Closed
Douglashdaniel opened this issue Jul 1, 2024 · 1 comment · Fixed by brave/brave-core#24469
Closed

Add Refresh Quote Button to Swap and Bridge #39513

Douglashdaniel opened this issue Jul 1, 2024 · 1 comment · Fixed by brave/brave-core#24469
Assignees
@Douglashdaniel
Labels
enhancement feature/web3/wallet Integrating Ethereum+ wallet support feature-request front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.69.x - Release

Comments

@Douglashdaniel
Copy link

Platforms

Linux, macOS, Windows

Description

We need to add a Refresh quote button to the Swap and Bridge screens to allow user fetch a new quote instead of waiting.

Screenshot
@Douglashdaniel Douglashdaniel added enhancement QA/Yes release-notes/include feature-request feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Jul 1, 2024
@Douglashdaniel Douglashdaniel self-assigned this Jul 1, 2024
@Douglashdaniel Douglashdaniel mentioned this issue Jul 2, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.69.x - Nightly milestone Jul 2, 2024
@srirambv
Copy link
Contributor

srirambv commented Aug 7, 2024

Verification passed on

Brave 1.69.136 Chromium: 127.0.6533.88 (Official Build) beta (64-bit)
Revision 47255350e0d135b2172cb9dd2ba344d3d7fe4572
OS Windows 11 Version 23H2 (Build 22631.3880)
  • Verified steps from brave/brave-core#24469
  • Verified Refresh Quote button is shown on both Swap and Bridge screen
  • Verified able to manually refresh quote by clicking the Refresh Quote button
  • Verified works for all providers
39513.mp4

@LaurenWags LaurenWags mentioned this issue Aug 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
enhancement feature/web3/wallet Integrating Ethereum+ wallet support feature-request front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.69.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Refresh Quote Button brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/brave/brave-browser/issues/39513

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy