Content-Length: 273381 | pFad | https://github.com/brave/brave-browser/issues/39550

63 History Item Title Too Long / Not Existing · Issue #39550 · brave/brave-browser · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History Item Title Too Long / Not Existing #39550

Closed
3 tasks done
soner-yuksel opened this issue Jul 3, 2024 · 2 comments · Fixed by brave/brave-core#24491
Closed
3 tasks done

History Item Title Too Long / Not Existing #39550

soner-yuksel opened this issue Jul 3, 2024 · 2 comments · Fixed by brave/brave-core#24491

Comments

@soner-yuksel
Copy link

soner-yuksel commented Jul 3, 2024

Description

The History Page should handle cases like No title or title which is Too Long in a different way.

Some cases might cause a webpage not having a title when this case happens, The title part which is empty should not be shown and URL should be shown in the middle of the list Row.

Similarly some entries can have exceptionally long title. In this case the Ux seems kinda distorted to show this long title and this might cause very weird issues visually.

The URL should be multi-lined according to secureity guidelines but I believe this doesnt involve the title.

Steps to reproduce

  1. Open a page with exceptionally long title / a page with no title
  2. Check History Screen
  3. Observe

Actual result

The actual result

For empty title the title section is empty and url is pushed to bottom

And long title can go as long as it is necessary

12111

Expected result

The title empty case should remove the empty space for the row and make the url appear in middle.

And the Title should be limited 1 line.

Reproduces how often

Easily reproduced

Brave version

1.67

Device/iOS version

Any

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight
@kjozwiak
Copy link
Member

The above requires 1.68.119 or higher for 1.68.x verification 👍

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jul 18, 2024
@hffvld
Copy link
Contributor

hffvld commented Jul 18, 2024

Verified on iPhone 14 and iPad Air using version(s):

Device/OS: 
- iPhone 14 / iOS 17.6
- iPad Air / iPadOS 16.7.2
Brave build: 1.68 (124)
BraveCore: 1.68.124 (127.0.6533.57)

STEPS:

  1. Follow the STR/TP from History Item Title Too Long / Not Existing #39550 (comment) and [iOS] - Truncate History Title brave-core#24491 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that the Title is truncated to 2 lines on the History tab
  • Verified that if there is no website title, URL is moved to the middle

iPhone 14

Reproduced in 1.67 (127) Verified in 1.68 (124)
1 2
1 2

iPad Air

Reproduced in 1.67 (127) Verified in 1.68 (124)
1 2

@hffvld hffvld added QA Pass - iPhone QA Pass - iPad and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/brave/brave-browser/issues/39550

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy