Content-Length: 249208 | pFad | https://github.com/brave/brave-browser/issues/39652

ED [Wallet] Add "Watch-Only" label to NFT grid items · Issue #39652 · brave/brave-browser · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wallet] Add "Watch-Only" label to NFT grid items #39652

Closed
josheleonard opened this issue Jul 9, 2024 · 1 comment · Fixed by brave/brave-core#24569
Closed

[Wallet] Add "Watch-Only" label to NFT grid items #39652

josheleonard opened this issue Jul 9, 2024 · 1 comment · Fixed by brave/brave-core#24569
Assignees
@josheleonard
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support feature-request front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.69.x - Release

Comments

@josheleonard
Copy link

Platforms

all

Description

We should label NFTs as "Watch-Only" that are not owned by any of the user's accounts

https://www.figma.com/design/mvoB5HzIyQT9O4vbcA1XhP/NFT-(Wallet-2.0)?node-id=1866-92147&m=dev
@josheleonard josheleonard added QA/Yes release-notes/include feature-request feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes labels Jul 9, 2024
@josheleonard josheleonard self-assigned this Jul 9, 2024
@josheleonard josheleonard mentioned this issue Jul 9, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.69.x - Nightly milestone Jul 10, 2024
@srirambv
Copy link
Contributor

srirambv commented Aug 9, 2024

Verification passed on

Brave 1.69.138 Chromium: 127.0.6533.100 (Official Build) beta (64-bit)
Revision 2569cce791e23282c250db59de277f2e81c33d9b
OS Windows 11 Version 23H2 (Build 22631.3880)
  • Verified steps from brave/brave-core#24569
  • Verified Watch-Only label is shown for all unowned NFTs
  • Verified Watch list message is shown on NFT details screen for unowned NFTs
39652.mp4

@LaurenWags LaurenWags mentioned this issue Aug 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josheleonard josheleonard

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support feature-request front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.69.x - Release
Development

Successfully merging a pull request may close this issue.

Feat(wallet): add watch only label and alerts to unowned NFTs brave/brave-core
3 participants
@srirambv @josheleonard @brave-builds








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/brave/brave-browser/issues/39652

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy