Content-Length: 267483 | pFad | https://github.com/brave/brave-browser/issues/40407

40 Extend LiFi swap support to other EVM chains · Issue #40407 · brave/brave-browser · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend LiFi swap support to other EVM chains #40407

Closed
2 of 6 tasks
onyb opened this issue Aug 12, 2024 · 2 comments · Fixed by brave/brave-core#25086
Closed
2 of 6 tasks

Extend LiFi swap support to other EVM chains #40407

onyb opened this issue Aug 12, 2024 · 2 comments · Fixed by brave/brave-core#25086
Assignees
@onyb
Labels
feature/web3/wallet/core feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.69.x - Release

Comments

@onyb
Copy link
Member

onyb commented Aug 12, 2024 •
edited
Loading

Description

Currently we only support LiFi for the chains that are already supported by 0x API. We need to extend this support to other EVM networks.

Steps to reproduce

  1. Make sure Gnosis chain is added to visible networks
  2. Go to Swap

Actual result

Gnosis chain is not visible in the network dropdown of token selection modal.

Expected result

Gnosis chain should be visible in the network dropdown of token selection modal. User should be able to fetch a valid quote, create a transaction, and confirm it on the network. Ensure that the SafeSign screen for the swap is rendered correctly.

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.69.x

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response
@onyb onyb mentioned this issue Aug 12, 2024
Merged
24 tasks
@onyb onyb self-assigned this Aug 12, 2024
@brave-builds brave-builds added this to the 1.70.x - Nightly milestone Aug 12, 2024
@brave-builds brave-builds mentioned this issue Aug 12, 2024
Merged
7 tasks
@kjozwiak
Copy link
Member

The above requires 1.69.146 or higher for 1.69.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.69.147 Chromium: 128.0.6613.40 (Official Build) (64-bit)
Revision d29b1747d0f906239936b0d94c40889920ebf2c0
OS Windows 11 Version 23H2 (Build 22631.4037)
  • Verified steps from issue description
  • Verified Gnosis is supported in Bridge
  • Verified Gnosis bridge successfully provides quotes
40407.mp4

@LaurenWags LaurenWags mentioned this issue Aug 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
feature/web3/wallet/core feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.69.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): extend LiFi swap support to other EVM chains brave/brave-core
4 participants
@kjozwiak @onyb @srirambv @brave-builds








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/brave/brave-browser/issues/40407

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy