Content-Length: 256012 | pFad | https://github.com/github/github-mcp-server/issues/780

27 Use slog for logging instead of logrus · Issue #780 · github/github-mcp-server · GitHub
Skip to content

Use slog for logging instead of logrus #780

@ricochet

Description

@ricochet

Describe the bug

Logrus is in maintenance mode and is readily replaced by slog in go's standard library.

I am experimenting with running GitHub's MCP server as a Wasm component. Logrus does not compile but slog does.

Steps to reproduce the behavior

GOOS=wasip1 GOARCH=wasm go build -o github-mcp-server.wasm ./cmd/github-mcp-server/main.go

# github.com/sirupsen/logrus
../../../go/pkg/mod/github.com/sirupsen/logrus@v1.9.3/terminal_check_notappengine.go:13:10: undefined: isTerminal

Expected vs actual behavior

Replacing logrus with slog should result in no change in runtime behavior, however by replacing a third party dependency with the standard library, additional compilation targets like Wasm are available.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions









      ApplySandwichStrip

      pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


      --- a PPN by Garber Painting Akron. With Image Size Reduction included!

      Fetched URL: https://github.com/github/github-mcp-server/issues/780

      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy