-
Notifications
You must be signed in to change notification settings - Fork 414
🧱 Integrate SetFit library #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Tom!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Let's please add to https://github.com/huggingface/huggingface.js/blob/main/packages/tasks/src/library-to-tasks.ts#L36 in this PR. This is automatically generated when merging a PR in the community repo (such as huggingface/api-inference-community#359), so you would still need to add a PR later on
@osanseviero So I should update that file (manually)? I figured I shouldn't touch it as it's automatically generated. |
Yes. At the moment the file is actually not generated automatically. The mapping is generated automatically (see https://github.com/huggingface/api-inference-community/actions/runs/7057881147/job/19212375912), but the file is then updated manually. |
I see, I see! I'll get on it. Edit: Done. |
Do I need to concern myself with the linting/test failure? I'd like to get this & huggingface/hub-docs#1150 merged tomorrow. |
@tomaarsen I launched a new run, seeing that this was merged earlier: #392 |
Awesome! Looks like it worked |
Thanks @osanseviero, @pcuenca & @merveenoyan for the reviews on these PRs! |
Hello!
Pull Request overview
Details
SetFit is a library for text classification with ~1200 models on the Hub at the time of writing. A v1.0.0 release is upcoming, and it's a good time to add this widget support, etc. It can be used like so:
I've previously integrated a library by only editing hub-docs and api-inference-community, but I see that there's been some refactors since. I hope that with these changes, I've edited the correct places. I also noticed this file: https://github.com/huggingface/huggingface.js/blob/main/packages/tasks/src/library-to-tasks.ts#L36, but it seems that it's automatically updated. So, I didn't touch that one.
Let me know if there's any more changes needed!
Related PRs: