Implementation of New MyList Design #8878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mekarpeles
added
the
Needs: Submitter Input
|
Overflows when > 4 lists I think in the 
On the 
|
github-actions
bot
removed
the
Needs: Submitter Input
|
The class
Edit: Tracked by #9385 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7704 (resubmission of #8725
This pull request refactors code from #7743, and adds a new section of mybooks where a user's first three lists are graphically previewed. The list object in openlibrary/core was given a new method that caches a small dictionary with memcached for up to ten minutes, containing a dict with near-minimal data for each list.
Technical
imply create a list, and navigate to your 'My Books' page. Importantly, there are some situations in which covers will not load; certain methods of adding a book to one's list add a Work, rather than an Edition. Works seem to rarely have associated covers, so will rarely display correctly. I was advised that solving that is outside of the scope of this Pull Request, so I'll merely be documenting my currently known methods.
Currently known ways that add a work;
The edit UI of the list.
The Solr Book Search
Currently known ways that add an edition:
-navigating to an edition page, and manually adding the book via the 'want to read' dropdown.
Testing
Create a list, add a few books, and then head to your MyLists page.
Screenshot
Stakeholders
@mekarpeles