allows librarians to view edition search #9093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RayBB
requested changes
Apr 16, 2024
There was a problem hiding this comment.
@quackers2 can you change it to use is_librarian() and is_super_librarian()?
Thanks!
RayBB
added
the
Needs: Submitter Input
|
@RayBB Done! |
RayBB
approved these changes
Apr 16, 2024
RayBB
added
Needs: Staff / Internal
|
lgtm, ty! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9054
Feature
Technical
Added another check for librarians when displaying the edition search checkbox
Testing
Logged in as AccountBot and searching something, the "solr edition" checkbox should not be visible. After adding AccountBot as a librarian, the checkbox should be visible.
Screenshot
Before Adding AccountBot as librarian:
After Adding AccountBot as librarian:
Stakeholders
@RayBB
@seabelis