-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Arrow to dropdown list #9135
Conversation
@Spedi your changes seem to have some unintended effects on the dropdown. Making a big indent and showing new text.
|
That's weird, I'll have a look at the codebase to find some answers. Do you have any idea about what this can be related to? |
I suppose the error I made is that the changes "copy" the dropdown list that's on the Want to Read button, so they inherit the indentation and the unwanted text. Do you think that's a possible explanation of the bug? |
The problem seems to go away if I add |
Changing everything as it was before the PR, and changing the visibility of arrow to visible in the |
@Spedi in reviewing your PR, I also noticed that it is weird that the visibility is set to hidden in some cases. I don't have the time to dig into it now but perhaps if you can uncover that (it could be in the JS?) then you might be able to find a nice solution. |
I'm still trying to work on it. |
It can be the CSS specifically. It likely has to do with nested css which can make it a bit tricky to untangle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Spedi, when a If you're doing a lot of CSS work, it may be better to run the following:
|
@jimchamp Should I run |
Yes. Your web container needs to be running, so run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Will revert the my_books/dropper
, then merge when the tests pass.
Closes #9065
This PR makes sure to correctly show the arrow on the Add to List dropdown button on the Author page.
Testing
Screenshot
Stakeholders
@RayBB