Chunk keys in lazy-thing-preview; fix long lists editing #9539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9539 +/- ##
==========================================
- Coverage 16.17% 16.13% -0.04%
==========================================
Files 90 90
Lines 4736 4746 +10
Branches 824 825 +1
==========================================
Hits 766 766
- Misses 3453 3463 +10
Partials 517 517 ☔ View full report in Codecov by Sentry. |
|
@rebecca-shoptaw Would you be able to take a look at this one? |
rebecca-shoptaw
added
the
Needs: Staff / Internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9535 . Fixes lists with many items timing out when lazy-rendering the book titles/covers.
Technical
Testing
Before: https://openlibrary.org/people/el4ctr0n/lists/OL235242L/Specific_History_Books/edit
After: https://testing.openlibrary.org/people/el4ctr0n/lists/OL235242L/Specific_History_Books/edit
Screenshot
Stakeholders