Aggregate want to read counts by author #9545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbdeitch
changed the title
cdrini
requested changes
Jul 19, 2024
cdrini
changed the title
cdrini
reviewed
Jul 31, 2024
cdrini
reviewed
Jul 31, 2024
cdrini
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9359
This PR adds summed counts for each of an authors's works' readinglog counts to the author, which will be useful for popularity measures later down the line.
Technical
The request sent to Solr has been changed to use the Solr JSON endpoint, thus necessitating it to be a POST request rather than GET. This allows for aggregations like 'sum' to be easily executed within the request.
A few changes to the return format were made, due to the way in which the Facet API returns data. Notably, each facet is now under the same category, with 'subject', 'place' and '
Testing
Simply edit an author's page or reindex their key via the Admin Solr endpoint, and look for the new 'want_to_read_count' or 'readinglog_facets` categories upon requesting their Solr data.
Screenshot
Stakeholders
@cdrini