Replace jQuery validate in admin and support forms
#9607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9607 +/- ##
==========================================
+ Coverage 16.06% 16.21% +0.15%
==========================================
Files 90 90
Lines 4769 4786 +17
Branches 832 829 -3
==========================================
+ Hits 766 776 +10
- Misses 3480 3486 +6
- Partials 523 524 +1 ☔ View full report in Codecov by Sentry. |
cdrini
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subtask of #9605.
Feature. Replaces jQuery
validaterequired field and email validation with built-in HTML validation to improve performance, JS-disabled functionality, and internationalization.Technical
Quite simple! Just removed the
validateclass (which triggers the plugin), and replaced eachclass="required"with the HTMLrequiredattribute and eachclass="email"with the HTMLtype="email"attribute.Also involved some CSS fixes to keep input styling consistent, same fixes should hold for all relevant PRs.
Testing
/contactScreenshot
Stakeholders
@cdrini