gitbook assets #1052
gitbook assets #1052
Conversation
montanalow
force-pushed
the
montana/gitbook
branch
from
a67ca67 to
2fd0276
Compare
| render(cluster, &path, guides, "Guides", &Path::new("docs")).await | ||
| use rocket::fs::NamedFile; | ||
|
|
||
| #[get("/docs/guides/.gitbook/assets/<path>", rank = 10)] |
There was a problem hiding this comment.
There was a problem hiding this comment.
Can't use the fileserver because we need the path to not be exact, but rather the relative gitbook path.
| @@ -48,7 +48,7 @@ | |||
| </li> | |||
|
|
|||
| <li class="nav-item d-flex align-items-center"> | |||
| <a class="nav-link p-lg-0" href="/docs/guides/setup/quick_start_with_docker">Docs</a> | |||
| <a class="nav-link p-lg-0" href="/docs/guides/README">Docs</a> | |||
There was a problem hiding this comment.
Yeah, but we can't control this lever in gitbook... and then again... it is kinda devvy.
| .header_counter | ||
| .fetch_add(1, std::sync::atomic::Ordering::SeqCst); | ||
| let id = format!("header-{}", id); | ||
| let id = meta.content.to_case(convert_case::Case::Kebab); |
There was a problem hiding this comment.
Not unique enough, we have duplicate headers in blogs and docs.
There was a problem hiding this comment.
We should dedup them. URLS are part of the UX, and we're also losing control of this to gitbook.
|
Do you think we should place these into We should at least go through these to validate that all the basics are there and we haven't removed important information. |
TODO