Content-Length: 311886 | pFad | https://github.com/postgresml/postgresml/pull/1060

1A Added a custom Option type and extended the select and added a few new classes for typography by SilasMarvin · Pull Request #1060 · postgresml/postgresml · GitHub
Skip to content

Added a custom Option type and extended the select and added a few new classes for typography #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

SilasMarvin
Copy link
Contributor

No description provided.

.text-white {
color: #{$gray-100} !important;
}
.text-gradient-blue {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a mixin for this would prevent the repetition.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me update this. I haven't used mixins before

Copy link
Contributor

@levkk levkk Oct 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

classes are better than mixins, mixings generate a ton of repetitive css code, while classes inherit and cascade. That's why bootstrap has .btn and .btn-primary classes separately. .btn styles a lot of the button while .btn-primary just changes the color, which is just one or two lines of css.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@extend is also an option that minimizes css code (same as having two classes) and reduces the number of classes an element needs to take. If we do go with two classes here we should have the _typographic class .text-gradient then a utility class for all the gradients so they can be applies as text color, background color, border color ect.

@SilasMarvin SilasMarvin merged commit ff02581 into master Oct 10, 2023
@SilasMarvin SilasMarvin deleted the silas-new-home branch October 10, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/postgresml/postgresml/pull/1060

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy