update dependencies for dashboard #1108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levkk
reviewed
Oct 21, 2023
| rocket = { git = "https://github.com/SergioBenitez/Rocket", features = ["secrets", "json"] } | ||
| sailfish = "0.8" | ||
| sailfish = "0.8.0" # 0.8.1 has breaking changes |
There was a problem hiding this comment.
Templates no longer compile, due to missing min/max args. It's not clear why, since those variables are not declared by our templates.
There was a problem hiding this comment.
Just need to clean the template cache. cargo clean
There was a problem hiding this comment.
I think you may be right. I filed the issue with the authors: rust-sailfish/sailfish#137
There was a problem hiding this comment.
Easy fix: rust-sailfish/sailfish#138
Debugging is actually pretty fun!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.