Allow to push down clauses from HAVING to WHERE when grouping sets are used.

anarazel · anarazel · commit 61444bfb809d · 2015-07-26T16:50:20.000+02:00
Previously we disallowed pushing down quals to WHERE in the presence of
grouping sets. That's overly restrictive.

We now instead copy quals to WHERE if applicable, leaving the
one in HAVING in place. That's because, at that stage of the planning
process, it's nontrivial to determine if it's safe to remove the one in
HAVING.

Author: Andrew Gierth
Discussion: 874mkt3l59.fsf@news-spur.riddles.org.uk
Backpatch: 9.5, where grouping sets were introduced. This isn't exactly
    a bugfix, but it seems better to keep the branches in sync at this point.
diff --git a/src/backend/optimizer/plan/planner.c b/src/backend/optimizer/plan/planner.c
@@ -570,13 +570,12 @@ subquery_planner(PlannerGlobal *glob, Query *parse,
 
 		if (contain_agg_clause(havingclause) ||
 			contain_volatile_functions(havingclause) ||
-			contain_subplans(havingclause) ||
-			parse->groupingSets)
+			contain_subplans(havingclause))
 		{
 			/* keep it in HAVING */
 			newHaving = lappend(newHaving, havingclause);
 		}
-		else if (parse->groupClause)
+		else if (parse->groupClause && !parse->groupingSets)
 		{
 			/* move it to WHERE */
 			parse->jointree->quals = (Node *)

Original file line number	Diff line number	Diff line change
`@@ -570,13 +570,12 @@ subquery_planner(PlannerGlobal glob, Query parse,`
`570`	`570`
`571`	`571`	`if (contain_agg_clause(havingclause) \|\|`
`572`	`572`	`contain_volatile_functions(havingclause) \|\|`
`573`		`- contain_subplans(havingclause) \|\|`
`574`		`- parse->groupingSets)`
	`573`	`+ contain_subplans(havingclause))`
`575`	`574`	`{`
`576`	`575`	`/* keep it in HAVING */`
`577`	`576`	`newHaving = lappend(newHaving, havingclause);`
`578`	`577`	`}`
`579`		`- else if (parse->groupClause)`
	`578`	`+ else if (parse->groupClause && !parse->groupingSets)`
`580`	`579`	`{`
`581`	`580`	`/* move it to WHERE */`
`582`	`581`	`parse->jointree->quals = (Node *)`