to_char(): have format 'OF' only show the leading negative sign

bmomjian · bmomjian · commit 9b43d73b3f9b · 2015-04-28T21:02:57.000-04:00
Previously both hours and minutes displayed as negative.

Report by David Pozsar
diff --git a/src/backend/utils/adt/formatting.c b/src/backend/utils/adt/formatting.c
@@ -2507,7 +2507,7 @@ DCH_to_char(FormatNode *node, bool is_interval, TmToChar *in, char *out, Oid col
 				s += strlen(s);
 				if (tm->tm_gmtoff % SECS_PER_HOUR != 0)
 				{
-					sprintf(s, ":%02ld", (tm->tm_gmtoff % SECS_PER_HOUR) / SECS_PER_MINUTE);
+					sprintf(s, ":%02ld", abs(tm->tm_gmtoff % SECS_PER_HOUR) / SECS_PER_MINUTE);
 					s += strlen(s);
 				}
 				break;

Original file line number	Diff line number	Diff line change
`@@ -2507,7 +2507,7 @@ DCH_to_char(FormatNode node, bool is_interval, TmToChar in, char *out, Oid col`
`2507`	`2507`	`s += strlen(s);`
`2508`	`2508`	`if (tm->tm_gmtoff % SECS_PER_HOUR != 0)`
`2509`	`2509`	`{`
`2510`		`- sprintf(s, ":%02ld", (tm->tm_gmtoff % SECS_PER_HOUR) / SECS_PER_MINUTE);`
	`2510`	`+ sprintf(s, ":%02ld", abs(tm->tm_gmtoff % SECS_PER_HOUR) / SECS_PER_MINUTE);`
`2511`	`2511`	`s += strlen(s);`
`2512`	`2512`	`}`
`2513`	`2513`	`break;`