Content-Length: 259498 | pFad | https://github.com/postgrespro/postgres/commit/d3f4e8a8a78be60f3a971f1f8ef6acc2d0576e5f

28 Avoid formally-undefined use of memcpy() in hstoreUniquePairs(). · postgrespro/postgres@d3f4e8a · GitHub
Skip to content

Commit d3f4e8a

Browse files
committed
Avoid formally-undefined use of memcpy() in hstoreUniquePairs().
hstoreUniquePairs() often called memcpy with equal source and destination pointers. Although this is almost surely harmless in practice, it's undefined according to the letter of the C standard. Some versions of valgrind will complain about it, and some versions of libc as well (cf. commit ad520ec). Tweak the code to avoid doing that. Noted by Tomas Vondra. Back-patch to all supported versions because of the hazard of libc assertions. Discussion: https://postgr.es/m/bf84d940-90d4-de91-19dd-612e011007f4@fuzzy.cz
1 parent 9b63c13 commit d3f4e8a

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

contrib/hstore/hstore_io.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,8 @@ hstoreUniquePairs(Pairs *a, int32 l, int32 *buflen)
340340
{
341341
*buflen += res->keylen + ((res->isnull) ? 0 : res->vallen);
342342
res++;
343-
memcpy(res, ptr, sizeof(Pairs));
343+
if (res != ptr)
344+
memcpy(res, ptr, sizeof(Pairs));
344345
}
345346

346347
ptr++;

0 commit comments

Comments
 (0)








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/postgrespro/postgres/commit/d3f4e8a8a78be60f3a971f1f8ef6acc2d0576e5f

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy