Content-Length: 288136 | pFad | https://github.com/typescript-eslint/typescript-eslint/issues/11321

04 Enhancement: Move `PropertyDefinition.typeAnnotation` to `PropertyDefinition.key.typeAnnotation`? · Issue #11321 · typescript-eslint/typescript-eslint · GitHub
Skip to content

Enhancement: Move PropertyDefinition.typeAnnotation to PropertyDefinition.key.typeAnnotation? #11321

Open
@fisker

Description

@fisker

Before You File a Proposal Please Confirm You Have Done The Following...

Relevant Package

ast-spec

My proposal is suitable for this project

  • I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).

Description

For

class A{
	foo:number = 1
}

The :number is on PropertyDefinition.typeAnnotation.

But

const foo:number = 1

The :number is on VariableDeclarator.id.typeAnnotation.

This looks inconsistent to me.

We should use PropertyDefinition.typeAnnotation/VariableDeclarator.typeAnnotation or PropertyDefinition.key.typeAnnotation/VariableDeclarator.id.typeAnnotation.

Additional Info

I found this whiling creating an ESLint rule that inserts a value to PropertyDefinition.

I expect insert = 1 after PropertyDefinition.key to work, but

class A{
-	foo:number
+	foo = 1:number
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requesttriageWaiting for team members to take a look

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions









      ApplySandwichStrip

      pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


      --- a PPN by Garber Painting Akron. With Image Size Reduction included!

      Fetched URL: https://github.com/typescript-eslint/typescript-eslint/issues/11321

      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy