chore: migrate to pnpm #11248

xaos7991 · 2025-05-27T17:52:42Z

PR Checklist

Addresses an existing open issue: fixes Repo: Migrate from yarn to pnpm #10891
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

refactor: removed .yarn folder fix: changed overrides approach feat: changed references

Replacing variables

Migrate scripts to pnpm and replaced yarn reference

Replaced yarn reference with pnpm

Added rule schema types

Fixed types

Launching app pnpm

Resolved problems with babel types

docs: updated comments to reflect pnpm usage instead of yarn

xaos7991 · 2025-07-01T17:41:57Z

Hi @JoshuaKGoldberg, @JamesHenry, @bradzacher, @kirkwaiblinger, and the rest of the team! 👋

First of all, thank you for all the work you do maintaining this project — it’s a huge help to the community, and I really appreciate the time and care you put into it.

I was just wondering if there’s any chance a maintainer could take a look at this PR. I understand you're all busy, but since it hasn’t received a review from a maintainer yet, I’d be happy, along with @Jester175, to revise or adjust anything needed once there’s some feedback.

Thanks again!

# Conflicts: # tools/scripts/generate-sponsors.mts # yarn.lock

JamesHenry

Thanks for this @xaos7991!

Please kindly take a look at all the inline comments.

Additionally:

The changes to the dependency and task graphs of the workspace through this change of package manager are unexpected and make me nervous that scope creep has occurred. Can we achieve this change of package manager without changing the relationships in the repo please? If they need to be changed for correctness let's please discuss and potentially address in a follow up (or pre-requisite PR)
I am not familiar enough with -w exec so I will need to check out the PR to play with that in all the subpackages, which I will do when other tasks have been addressed.
I will push a commit to change the release setup once all other TODOs are addressed and the PR is green again

.github/actions/prepare-install/action.yml

.github/workflows/ci.yml

.github/workflows/nx-migrate.yml

JamesHenry · 2025-07-08T11:35:12Z

.github/workflows/nx-migrate.yml


-          YARN_ENABLE_IMMUTABLE_INSTALLS=false yarn install
+          pnpm install


The install should allow modifications:

# We need to expect lock file changes to be applicable pnpm install --ignore-scripts --frozen-lockfile=false

JamesHenry · 2025-07-08T11:35:25Z

.github/workflows/nx-migrate.yml


          # Sometimes Nx can require config formatting changes after a migrate command
-          YARN_ENABLE_IMMUTABLE_INSTALLS=false yarn install
-          yarn nx format
+          pnpm install


nx.json

packages/integration-tests/fixtures/eslint-v8/package.json

packages/integration-tests/tools/integration-test-base.ts

JamesHenry · 2025-07-08T11:50:46Z

tools/release/release.mts

@@ -43,12 +43,12 @@ const { projectsVersionData, workspaceVersion } = await releaseVersion({



This needs to be redone, you can leave it to me

Thank you so much!
It would be great if you could take care of that part - totally trust your judgment on it. Let me know if there's anything you'd like me to adjust on my side!

Jester175 · 2025-07-09T19:23:12Z

Thanks for this @xaos7991!

Please kindly take a look at all the inline comments.

Additionally:

The changes to the dependency and task graphs of the workspace through this change of package manager are unexpected and make me nervous that scope creep has occurred. Can we achieve this change of package manager without changing the relationships in the repo please? If they need to be changed for correctness let's please discuss and potentially address in a follow up (or pre-requisite PR)

I am not familiar enough with -w exec so I will need to check out the PR to play with that in all the subpackages, which I will do when other tasks have been addressed.

I will push a commit to change the release setup once all other TODOs are addressed and the PR is green again

During our work, we discovered that specifying a version like: "@typescript-eslint/rule-schema-to-typescript-types": "^8.36.0" - results in a 404 error from the npm registry.

However, referencing it as a workspace: "@typescript-eslint/rule-schema-to-typescript-types": "workspace:*" - works as expected with pnpm.

It seems this package isn't published publicly and is meant to be used internally within the monorepo. Might be worth clarifying to avoid confusion.

github-actions · 2025-07-09T19:23:25Z

Uh oh! @Jester175, at least one image you shared is missing helpful alt text. Check #11248 (comment) to fix the following violations:

Images should have meaningful alternative text (alt text) at line 16

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

.github/workflows/nx-migrate.yml

JamesHenry · 2025-07-15T09:32:09Z

.github/workflows/prettier-update.yml

@@ -20,10 +20,11 @@ jobs:
    name: Run prettier formatting if required
    runs-on: ubuntu-latest
    steps:
-      - uses: actions/checkout@v4
+      - uses: pnpm/action-setup@v4
+        if: ${{ steps.nrwl-workspace-package-check.outputs.was-changed == 'true' }}


Wrong condition ID reference and wrong place in the workflow (per previous comment)

It's also completely unchanged...

Ok sorry, looks like there was a github caching issue. It is now in the correct place, but the step ID is still wrong

Suggested change

if: ${{ steps.nrwl-workspace-package-check.outputs.was-changed == 'true' }}

if: ${{ steps.prettier-package-check.outputs.was-changed == 'true' }}

JamesHenry · 2025-07-15T09:34:39Z

package.json

-  "resolutions": {
-    "@types/eslint-scope": "link:./tools/dummypkg",
-    "@types/eslint": "link:./tools/dummypkg",
-    "@types/estree": "link:./tools/dummypkg",
-    "@types/node": "^22.0.0",
-    "@types/react": "^18.2.14",
-    "eslint-plugin-eslint-plugin@^5.5.0": "patch:eslint-plugin-eslint-plugin@npm%3A5.5.1#./.yarn/patches/eslint-plugin-eslint-plugin-npm-5.5.1-4206c2506d.patch",
-    "prettier": "3.5.0",
-    "react-split-pane@^0.1.92": "patch:react-split-pane@npm%3A0.1.92#./.yarn/patches/react-split-pane-npm-0.1.92-93dbf51dff.patch",
-    "tsx": "^4.7.2",
-    "typescript": "5.8.2"
-  },


I don't think these can casually be removed and leave things to "*" references in the dependences/devDependencies.

Maybe @bradzacher can give feedback on the specifics

Oh sorry, I see the overrides config in pnpm-workspace.yaml

I'd still be curious to get sign off from Brad on the whole "link:./tools/dummypkg" thing, I can't remember off the top of my head what that is about

JamesHenry · 2025-07-15T09:44:40Z

@Jester175

During our work, we discovered that specifying a version like: "@typescript-eslint/rule-schema-to-typescript-types": "^8.36.0" - results in a 404 error from the npm registry.

That's because in pnpm 10+ you have to opt into it linking workspace packages by version number reference:

https://pnpm.io/cli/recursive#--link-workspace-packages

It's totally fine that we are switching to workspace:* references (that's a desirable thing as part of this move), but I'm still just surprised that changes to the project and task relationships were required, e.g. you have altered a few dependsOn and added new dependency references like

It's not replacing a version number reference.

Again, if these are required, and somehow yarn was causing us to miss them, that's one thing, but I want to make sure we are clearly explaining why this was necessary in each case

github-actions · 2025-07-15T09:44:57Z

Uh oh! @JamesHenry, at least one image you shared is missing helpful alt text. Check #11248 (comment) to fix the following violations:

Images should have meaningful alternative text (alt text) at line 10

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

# Conflicts: # packages/eslint-plugin/package.json # packages/type-utils/package.json # yarn.lock

xaos7991 · 2025-07-15T11:41:44Z

@Jester175

During our work, we discovered that specifying a version like: "@typescript-eslint/rule-schema-to-typescript-types": "^8.36.0" - results in a 404 error from the npm registry.

That's because in pnpm 10+ you have to opt into it linking workspace packages by version number reference:

https://pnpm.io/cli/recursive#--link-workspace-packages

It's totally fine that we are switching to workspace:* references (that's a desirable thing as part of this move), but I'm still just surprised that changes to the project and task relationships were required, e.g. you have altered a few dependsOn and added new dependency references like

It's not replacing a version number reference.

Again, if these are required, and somehow yarn was causing us to miss them, that's one thing, but I want to make sure we are clearly explaining why this was necessary in each case

The addition of @types/json-schema was necessary because TypeScript was complaining about missing type declarations when using the json-schema package in areOptionsValid.ts:

Also added @types/react — a few tests were relying on React types and started failing without them.
Falling tests:

github-actions · 2025-07-15T11:41:58Z

Uh oh! @xaos7991, at least one image you shared is missing helpful alt text. Check #11248 (comment) to fix the following violations:

Images should have meaningful alternative text (alt text) at line 9
Images should have meaningful alternative text (alt text) at line 16
Images should have meaningful alternative text (alt text) at line 25

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

# Conflicts: # yarn.lock

xaos7991 and others added 30 commits May 18, 2025 21:32

feat: migrated to pnpm

0b9c67d

refactor: removed .yarn folder fix: changed overrides approach feat: changed references

fix: replaced the variable with your own path

d78c30d

fix: changed init path

e738b1b

fix: added files to ignore

8227be7

fix: changed init path

e1080b5

Merge pull request #2 from xaos7991/replacing-variables

ae63c55

Replacing variables

chore: migrated scripts from yarn to pnpm

e4500eb

chore: migrate scripts to pnpm

78f97ca

chore: replaced yarn reference with pnpm

b2740d3

chore: replaced yarn reference with pnpm

47bca3f

Merge pull request #4 from xaos7991/chore/migrate-scripts-to-pnpm

caae48b

Migrate scripts to pnpm and replaced yarn reference

chore: replaced yarn reference with pnpm

6ff72a1

Merge pull request #5 from xaos7991/chore/migrate-scripts-to-pnpm

83ea658

Replaced yarn reference with pnpm

chore: added rule schema types

df07c3c

Merge pull request #6 from xaos7991/chore/add-rule-schema-types

0ffc5cc

Added rule schema types

chore: fixed types

feb01b1

Merge pull request #7 from xaos7991/chore/types

9ed6376

Fixed types

ci: migrated yarn to pnpm

a497ac5

fix: resolved issues with eslint-plugin tests

351de42

chore: migrated to pnpm

03bd8d3

Merge pull request #8 from xaos7991/chore/launching-app-pnpm

1de3fca

Launching app pnpm

fix: resolved problems with versions of babel packages

77ca6dd

fix: resolved problems with babel types

644216b

Merge pull request #9 from xaos7991/fix/babel-types

0fe7f92

Resolved problems with babel types

docs: updated comments to reflect pnpm usage instead of yarn

a6f9007

Merge pull request #10 from xaos7991/chore/docs-update-pnpm-comments

08f458c

docs: updated comments to reflect pnpm usage instead of yarn

ci: migrated from yarn to pnpm

de5ee8b

ci: removed pnpm version

46e0620

fix: added dependency ignore configuration

88af74c

fix: added dependency ignore configuration

7e51137

xaos7991 added 6 commits July 5, 2025 11:19

Merge branch 'main' into migrate-to-pnpm

a3c82cd

# Conflicts: # tools/scripts/generate-sponsors.mts # yarn.lock

fix: resolved lint issue

fd1df19

Merge branch 'main' into migrate-to-pnpm

d214d1b

fix: got rid of yarn

50e3938

fix: added dependency to build

c123198

fix: resolved issue

aafacea

kirkwaiblinger requested a review from a team July 6, 2025 22:22

JamesHenry requested changes Jul 8, 2025

View reviewed changes

Jester175 and others added 3 commits July 9, 2025 11:33

Merge remote-tracking branch 'origen/main' into migrate-to-pnpm

aa07223

fix: resolved issue

6da2a7a

fix: try to get rid of checkout

75e3231

Merge branch 'main' into migrate-to-pnpm

a864d53

xaos7991 requested a review from JamesHenry July 9, 2025 19:23

JamesHenry reviewed Jul 15, 2025

View reviewed changes

.github/workflows/nx-migrate.yml Show resolved Hide resolved

JamesHenry reviewed Jul 15, 2025

View reviewed changes

xaos7991 added 3 commits July 15, 2025 13:11

Merge branch 'main' into migrate-to-pnpm

253a6b0

# Conflicts: # packages/eslint-plugin/package.json # packages/type-utils/package.json # yarn.lock

chore: bumped pnpm version

dd9d19c

fix: resolved issues

e0f7582

Merge branch 'main' into migrate-to-pnpm

ac83e81

# Conflicts: # yarn.lock

xaos7991 requested a review from JamesHenry July 15, 2025 11:45

Jester175 and others added 2 commits July 15, 2025 15:24

Merge branch 'main' into migrate-to-pnpm

22dc214

Merge branch 'main' into migrate-to-pnpm

80ffa6f


		YARN_ENABLE_IMMUTABLE_INSTALLS=false yarn install
		pnpm install

		@@ -43,12 +43,12 @@ const { projectsVersionData, workspaceVersion } = await releaseVersion({

	if: ${{ steps.nrwl-workspace-package-check.outputs.was-changed == 'true' }}
	if: ${{ steps.prettier-package-check.outputs.was-changed == 'true' }}

Uh oh!

chore: migrate to pnpm #11248

Are you sure you want to change the base?

chore: migrate to pnpm #11248

Conversation

xaos7991 commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

xaos7991 commented Jul 1, 2025

Uh oh!

JamesHenry left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Jester175 commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 9, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JamesHenry commented Jul 15, 2025

Uh oh!

github-actions bot commented Jul 15, 2025

Uh oh!

xaos7991 commented Jul 15, 2025

Uh oh!

github-actions bot commented Jul 15, 2025

Uh oh!

Uh oh!

xaos7991 commented May 27, 2025 •

edited

Loading

Jester175 commented Jul 9, 2025 •

edited

Loading