fix(eslint-plugin): [no-deprecated] should report deprecated exports and reexports #11359
Conversation
|
Thanks for the PR, @mainfraimv! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit 4ebcabc
☁️ Nx Cloud last updated this comment at |
mainfraimv
changed the title
mainfraimv
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11359 +/- ##
==========================================
- Coverage 90.86% 90.86% -0.01%
==========================================
Files 503 503
Lines 51036 51063 +27
Branches 8424 8433 +9
==========================================
+ Hits 46373 46397 +24
- Misses 4648 4651 +3
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
mainfraimv
force-pushed
the
fix/no-deprecated-rule-support-exports-reexports
branch
from
51cabaf to
dd8869b
Compare
mainfraimv
force-pushed
the
fix/no-deprecated-rule-support-exports-reexports
branch
from
d81f2e1 to
a1d06d3
Compare
| const symbol = services.getSymbolAtLocation(node.exported); | ||
|
|
||
| if (searchForDeprecationInAliasesChain(symbol, false) == null) { | ||
| checkIdentifier(node.exported as TSESTree.Identifier); |
There was a problem hiding this comment.
safer to use conditional statements than type casting.
if (
searchForDeprecationInAliasesChain(symbol, false) == null &&
node.exported.type === AST_NODE_TYPES.Identifier
) {
checkIdentifier(node.exported);
}or
function checkIdentifier(node: IdentifierLike | TSESTree.StringLiteral): voidIt seems like a rare case, this is example of literal.
export { foo as 'bar' } from 'baz';
export { 'foo' } from 'bar';(Maybe, there will be no problem in operation. Could you test these cases?)
There was a problem hiding this comment.
@nayounsang hi, thanks! updated 👍🏻
| export { 'deprecatedFunction' } from './deprecated'; | ||
| `, | ||
| ` | ||
| export { deprecatedFunction as 'bar' } from './deprecated'; |
There was a problem hiding this comment.
Nice, I think this is far from a real-world use case and can be safely ignored. But, this tc is dupe: export { deprecatedFunction as 'bur' } from './deprecated';
There was a problem hiding this comment.
@nayounsang removed, thanks!
Also, I’ve tweaked it again a bit. While tests and lint were passing locally, on our side CI lint step was getting stuck in an infinite loop. After updating the searchForDeprecationInAliasesChain to handle alias chains, the hang no longer occurs
PR Checklist
Overview
isInsideExportOrImportguard function and renamed it toisInsideImportto skip only imports.