Content-Length: 16799 | pFad | https://postgr.es/m/CAKrAKeXt-=bgm=d+EDmcC9kWoikp8kbVb3LH0K3K+AGGsykpHQ@mail.gmail.com

PostgreSQL: Fix GetWALAvailability function code comments for WALAVAIL_REMOVED return value

Fix GetWALAvailability function code comments for WALAVAIL_REMOVED return value

From: sirisha chamarthi <sirichamarthi22(at)gmail(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Fix GetWALAvailability function code comments for WALAVAIL_REMOVED return value
Date: 2022-10-19 07:09:09
Message-ID: CAKrAKeXt-=bgm=d+EDmcC9kWoikp8kbVb3LH0K3K+AGGsykpHQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Hackers,

The current code comment says that the replication stream on a slot with
the given targetLSN can't continue after a restart but even without a
restart the stream cannot continue. The slot is invalidated and the
walsender process is terminated by the checkpoint process. Attaching a
small patch to fix the comment.

2022-10-19 06:26:22.387 UTC [144482] STATEMENT: START_REPLICATION SLOT
"s2" LOGICAL 0/0
2022-10-19 06:27:41.998 UTC [2553755] LOG: checkpoint starting: time
2022-10-19 06:28:04.974 UTC [2553755] LOG: terminating process 144482 to
release replication slot "s2"
2022-10-19 06:28:04.974 UTC [144482] FATAL: terminating connection due to
administrator command
2022-10-19 06:28:04.974 UTC [144482] CONTEXT: slot "s2", output plugin
"test_decoding", in the change callback, associated LSN 0/1E23AB68
2022-10-19 06:28:04.974 UTC [144482] STATEMENT: START_REPLICATION SLOT
"s2" LOGICAL 0/0

Thanks,
Sirisha

Attachment Content-Type Size
0001-Fix-GetWALAvailability-function-code-comments.patch application/octet-stream 1006 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2022-10-19 07:36:08 Re: Fix GetWALAvailability function code comments for WALAVAIL_REMOVED return value
Previous Message Bharath Rupireddy 2022-10-19 07:03:32 Re: Avoid memory leaks during base backups








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://postgr.es/m/CAKrAKeXt-=bgm=d+EDmcC9kWoikp8kbVb3LH0K3K+AGGsykpHQ@mail.gmail.com

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy