prop-types computed string format
#127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used list of nested names instead of dot-separated names to avoid conflict with properties like `this.props['this.format']`
Cellule
force-pushed
the
prop_types_computed_props
branch
from
b5d6bf8 to
144d45c
Compare
|
Very nice ❇️ With your PR-s there are already additional problems has been discovered in And what is the most important - they all are legitimate ✨ Thank you 🍒 |
|
@AlexKVal I'm really glad this will help improve your library (which I absolutely love btw) :) |
|
It is not my library 😊. |
|
Thanks! :) |
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion at #124 (comment)
Added support for prop-types check of type
this.props['this-format'].Used list of nested names instead of dot-separated names to avoid conflict with properties like
this.props['this.format']