Merge pull request #5085 from jbellenger/jbellenger/rawmodule-hash

sokra · web-flow · commit 3da4f3e89dc9 · 2017-06-18T19:51:21.000+02:00
fix RawModule hashing
diff --git a/lib/RawModule.js b/lib/RawModule.js
@@ -47,4 +47,8 @@ module.exports = class RawModule extends Module {
 			return new RawSource(this.sourceStr);
 	}
 
+	updateHash(hash) {
+		hash.update(this.sourceStr);
+		super.updateHash(hash);
+	}
 };
diff --git a/test/RawModule.test.js b/test/RawModule.test.js
@@ -6,6 +6,7 @@ const RawSource = require("webpack-sources").RawSource;
 const RequestShortener = require("../lib/RequestShortener");
 const should = require("should");
 const path = require("path");
+const crypto = require("crypto");
 
 describe("RawModule", () => {
 	let myRawModule;
@@ -62,4 +63,18 @@ describe("RawModule", () => {
 			}
 		);
 	});
+
+	describe("updateHash", () => {
+		it("should include sourceStr in its hash", () => {
+			const hashModule = (module) => {
+				const hash = crypto.createHash("sha256");
+				module.updateHash(hash);
+				return hash.digest("hex");
+			};
+
+			const hashFoo = hashModule(new RawModule("\"foo\""));
+			const hashBar = hashModule(new RawModule("\"bar\""));
+			hashFoo.should.not.equal(hashBar);
+		});
+	});
 });

Original file line number	Diff line number	Diff line change
`@@ -47,4 +47,8 @@ module.exports = class RawModule extends Module {`
`47`	`47`	`return new RawSource(this.sourceStr);`
`48`	`48`	`}`
`49`	`49`
	`50`	`+ updateHash(hash) {`
	`51`	`+ hash.update(this.sourceStr);`
	`52`	`+ super.updateHash(hash);`
	`53`	`+ }`
`50`	`54`	`};`