I wonder how others feel about this, but the spelling of
enable_partition_wise_join feels funny to me every time I look at it. I
would write it enable_partitionwise_join.

Thoughts?

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Peter Eisentraut wrote:
> I wonder how others feel about this, but the spelling of
> enable_partition_wise_join feels funny to me every time I look at it. I
> would write it enable_partitionwise_join.

+1

See also: https://postgr.es/m/20171005134847.shzldz2ublrb3ny2@alvherre.pgsql

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

On 14/02/18 09:27, Peter Eisentraut wrote:
> I wonder how others feel about this, but the spelling of
> enable_partition_wise_join feels funny to me every time I look at it. I
> would write it enable_partitionwise_join.
>
> Thoughts?
>
As 'wise' is a suffix, not a word in this situation - so it be combined
with 'partition'.

Hence 'enable_partitionwise_join' is more correct.

Cheers,
Gavin

On Wed, Feb 14, 2018 at 2:15 AM, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> Peter Eisentraut wrote:
>> I wonder how others feel about this, but the spelling of
>> enable_partition_wise_join feels funny to me every time I look at it. I
>> would write it enable_partitionwise_join.
>
> +1
>
> See also: https://postgr.es/m/20171005134847.shzldz2ublrb3ny2@alvherre.pgsql

To that I replied with
https://www.postgresql.org/message-id/CAFjFpRcsZnxCen88a-16R5EYqPCwFYnFThM%2Bmjagu%3DB1QvxPVA%40mail.gmail.com.
I didn't get any further response, so nothing was changed that time.
Alvaro, Peter, Gavin have voted for partitionwise in this thread and
Robert had similar objections earlier. Looks like we should change it.

--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company

On 2/14/18 03:28, Ashutosh Bapat wrote:
> On Wed, Feb 14, 2018 at 2:15 AM, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>> Peter Eisentraut wrote:
>>> I wonder how others feel about this, but the spelling of
>>> enable_partition_wise_join feels funny to me every time I look at it. I
>>> would write it enable_partitionwise_join.
>>
>> +1
>>
>> See also: https://postgr.es/m/20171005134847.shzldz2ublrb3ny2@alvherre.pgsql
>
> To that I replied with
> https://www.postgresql.org/message-id/CAFjFpRcsZnxCen88a-16R5EYqPCwFYnFThM%2Bmjagu%3DB1QvxPVA%40mail.gmail.com.
> I didn't get any further response, so nothing was changed that time.
> Alvaro, Peter, Gavin have voted for partitionwise in this thread and
> Robert had similar objections earlier. Looks like we should change it.

done

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

On Fri, Feb 16, 2018 at 9:09 PM, Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> On 2/14/18 03:28, Ashutosh Bapat wrote:
>> On Wed, Feb 14, 2018 at 2:15 AM, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>>> Peter Eisentraut wrote:
>>>> I wonder how others feel about this, but the spelling of
>>>> enable_partition_wise_join feels funny to me every time I look at it. I
>>>> would write it enable_partitionwise_join.
>>>
>>> +1
>>>
>>> See also: https://postgr.es/m/20171005134847.shzldz2ublrb3ny2@alvherre.pgsql
>>
>> To that I replied with
>> https://www.postgresql.org/message-id/CAFjFpRcsZnxCen88a-16R5EYqPCwFYnFThM%2Bmjagu%3DB1QvxPVA%40mail.gmail.com.
>> I didn't get any further response, so nothing was changed that time.
>> Alvaro, Peter, Gavin have voted for partitionwise in this thread and
>> Robert had similar objections earlier. Looks like we should change it.
>
> done

Thanks. There are functions like try_partition_wise_join(),
generate_partition_wise_join_paths() which use partition_wise
spelling. Should we update those as well?

--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company

On Mon, Feb 19, 2018 at 9:08 AM, Ashutosh Bapat
<ashutosh(dot)bapat(at)enterprisedb(dot)com> wrote:
>
> Thanks. There are functions like try_partition_wise_join(),
> generate_partition_wise_join_paths() which use partition_wise
> spelling. Should we update those as well?

I see that the commit already did that. Sorry. Although, I would have
liked comments to spell "partition-wise" instead of "partitionwise".
https://dictionary.cambridge.org/dictionary/english/wise
differentiates between "-wise" and "wise". The later is used when
indicating a direction and the first one indicates "relating to". I
think here we want the first one.

--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company