Merge pull request #9139 from internetarchive/fix/is_loaned_out

improved is_loaned_out logic
internetarchive · May 13, 2024 · 8e106b2 · 8e106b2
2 parents 1d86a59 + e89362b
commit 8e106b2
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/openlibrary/core/lending.py b/openlibrary/core/lending.py
@@ -551,7 +551,7 @@ def is_loaned_out(identifier: str) -> bool:
     return (
         is_loaned_out_on_ol(identifier)
         or is_loaned_out_on_acs4(identifier)
-        or is_loaned_out_on_ia(identifier)
+        or (is_loaned_out_on_ia(identifier) is True)
     )
 
 
@@ -561,7 +561,7 @@ def is_loaned_out_on_acs4(identifier: str) -> bool:
     return item.has_loan()
 
 
-def is_loaned_out_on_ia(identifier: str):
+def is_loaned_out_on_ia(identifier: str) -> bool | None:
     """Returns True if the item is checked out on Internet Archive."""
     url = "https://archive.org/services/borrow/%s?action=status" % identifier
     try: