Skip to content

Avoids purging el on unmount if el is not found #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

willleahy
Copy link

@willleahy willleahy commented Nov 23, 2022

Fixes an issue where unmount will be called after the page changes and this.el can no longer be found. In my case, this happened using react-plotly in a creat-react-app app + react-router app when the route changed away from a page using plotly.

Fixes an issue where, when changing a route in an SPA, unmount will be called after the page changes and this.el can no longer be found.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy