Repair two TIME WITH TIME ZONE bugs found by Dennis Vshivkov. Comparison

tglsfdc · tglsfdc · commit 9524c6b8aede · 2005-04-23T22:54:23.000Z
of timetz values misbehaved in --enable-integer-datetime cases, and
EXTRACT(EPOCH) subtracted the zone instead of adding it in all cases.
Backpatch to all supported releases (except --enable-integer-datetime code
does not exist in 7.2).
diff --git a/src/backend/utils/adt/date.c b/src/backend/utils/adt/date.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/utils/adt/date.c,v 1.64.2.3 2002/09/30 20:57:10 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/utils/adt/date.c,v 1.64.2.4 2005/04/23 22:54:23 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1553,7 +1553,7 @@ timetz_part(PG_FUNCTION_ARGS)
 		}
 	}
 	else if ((type == RESERV) && (val == DTK_EPOCH))
-		result = time->time - time->zone;
+		result = time->time + time->zone;
 	else
 	{
 		elog(ERROR, "TIMETZ units '%s' not recognized",

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/utils/adt/date.c,v 1.64.2.3 2002/09/30 20:57:10 tgl Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/utils/adt/date.c,v 1.64.2.4 2005/04/23 22:54:23 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -1553,7 +1553,7 @@ timetz_part(PG_FUNCTION_ARGS)`
`1553`	`1553`	`}`
`1554`	`1554`	`}`
`1555`	`1555`	`else if ((type == RESERV) && (val == DTK_EPOCH))`
`1556`		`- result = time->time - time->zone;`
	`1556`	`+ result = time->time + time->zone;`
`1557`	`1557`	`else`
`1558`	`1558`	`{`
`1559`	`1559`	`elog(ERROR, "TIMETZ units '%s' not recognized",`