Fix use of wrong variable in pg_receivewal's get_destination_dir().

anarazel · anarazel · commit 1155d8b8d52e · 2022-02-26T16:43:54.000-08:00
The global variable wrongly used is always the one passed to get_destination_dir(), so there currently are no negative consequences. Author: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> Discussion: https://postgr.es/m/CALj2ACUT0C2LQwhyLXTQdj8T9SxZa5j7cmu-UOz0cZ8_D5edjg@mail.gmail.com
diff --git a/src/bin/pg_basebackup/pg_receivewal.c b/src/bin/pg_basebackup/pg_receivewal.c
@@ -240,7 +240,7 @@ get_destination_dir(char *dest_folder)
 	dir = opendir(dest_folder);
 	if (dir == NULL)
 	{
-		pg_log_error("could not open directory \"%s\": %m", basedir);
+		pg_log_error("could not open directory \"%s\": %m", dest_folder);
 		exit(1);
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -240,7 +240,7 @@ get_destination_dir(char *dest_folder)`
`240`	`240`	`dir = opendir(dest_folder);`
`241`	`241`	`if (dir == NULL)`
`242`	`242`	`{`
`243`		`- pg_log_error("could not open directory \"%s\": %m", basedir);`
	`243`	`+ pg_log_error("could not open directory \"%s\": %m", dest_folder);`
`244`	`244`	`exit(1);`
`245`	`245`	`}`
`246`	`246`