Don't call fwrite() with len == 0 when writing out relcache init file.

anarazel · anarazel · commit 1c6bb380e5ab · 2022-03-23T13:05:25.000-07:00
Noticed via -fsanitize=undefined. Backpatch to all branches, for the same reasons as 46ab07f. Discussion: https://postgr.es/m/20220323173537.ll7klrglnp4gn2um@alap3.anarazel.de Backpatch: 10-
diff --git a/src/backend/utils/cache/relcache.c b/src/backend/utils/cache/relcache.c
@@ -6528,7 +6528,7 @@ write_item(const void *data, Size len, FILE *fp)
 {
 	if (fwrite(&len, 1, sizeof(len), fp) != sizeof(len))
 		elog(FATAL, "could not write init file");
-	if (fwrite(data, 1, len, fp) != len)
+	if (len > 0 && fwrite(data, 1, len, fp) != len)
 		elog(FATAL, "could not write init file");
 }
 

Original file line number	Diff line number	Diff line change
`@@ -6528,7 +6528,7 @@ write_item(const void data, Size len, FILE fp)`
`6528`	`6528`	`{`
`6529`	`6529`	`if (fwrite(&len, 1, sizeof(len), fp) != sizeof(len))`
`6530`	`6530`	`elog(FATAL, "could not write init file");`
`6531`		`- if (fwrite(data, 1, len, fp) != len)`
	`6531`	`+ if (len > 0 && fwrite(data, 1, len, fp) != len)`
`6532`	`6532`	`elog(FATAL, "could not write init file");`
`6533`	`6533`	`}`
`6534`	`6534`