Use l*_node() family of functions where appropriate

petere · petere · commit 2b00db4fb0c7 · 2021-07-19T08:20:24.000+02:00
Instead of castNode(…, lfoo(…)) Author: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org> Discussion: https://www.postgresql.org/message-id/flat/87eecahraj.fsf@wibble.ilmari.org
diff --git a/src/backend/commands/publicationcmds.c b/src/backend/commands/publicationcmds.c
@@ -514,7 +514,7 @@ OpenTableList(List *tables)
 	 */
 	foreach(lc, tables)
 	{
-		RangeVar   *rv = castNode(RangeVar, lfirst(lc));
+		RangeVar   *rv = lfirst_node(RangeVar, lc);
 		bool		recurse = rv->inh;
 		Relation	rel;
 		Oid			myrelid;
diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
@@ -4770,7 +4770,7 @@ ATRewriteCatalogs(List **wqueue, LOCKMODE lockmode,
 
 			foreach(lcmd, subcmds)
 				ATExecCmd(wqueue, tab,
-						  castNode(AlterTableCmd, lfirst(lcmd)),
+						  lfirst_node(AlterTableCmd, lcmd),
 						  lockmode, pass, context);
 
 			/*
@@ -12842,7 +12842,7 @@ ATPostAlterTypeParse(Oid oldId, Oid oldRelId, Oid refRelId, char *cmd,
 
 			foreach(lcmd, stmt->cmds)
 			{
-				AlterTableCmd *cmd = castNode(AlterTableCmd, lfirst(lcmd));
+				AlterTableCmd *cmd = lfirst_node(AlterTableCmd, lcmd);
 
 				if (cmd->subtype == AT_AddIndex)
 				{
@@ -16671,7 +16671,7 @@ transformPartitionSpec(Relation rel, PartitionSpec *partspec, char *strategy)
 	/* take care of any partition expressions */
 	foreach(l, partspec->partParams)
 	{
-		PartitionElem *pelem = castNode(PartitionElem, lfirst(l));
+		PartitionElem *pelem = lfirst_node(PartitionElem, l);
 
 		if (pelem->expr)
 		{
@@ -16708,7 +16708,7 @@ ComputePartitionAttrs(ParseState *pstate, Relation rel, List *partParams, AttrNu
 	attn = 0;
 	foreach(lc, partParams)
 	{
-		PartitionElem *pelem = castNode(PartitionElem, lfirst(lc));
+		PartitionElem *pelem = lfirst_node(PartitionElem, lc);
 		Oid			atttype;
 		Oid			attcollation;
 
diff --git a/src/backend/executor/execPartition.c b/src/backend/executor/execPartition.c
@@ -585,7 +585,7 @@ ExecInitPartitionInfo(ModifyTableState *mtstate, EState *estate,
 
 		foreach(ll, wcoList)
 		{
-			WithCheckOption *wco = castNode(WithCheckOption, lfirst(ll));
+			WithCheckOption *wco = lfirst_node(WithCheckOption, ll);
 			ExprState  *wcoExpr = ExecInitQual(castNode(List, wco->qual),
 											   &mtstate->ps);
 
diff --git a/src/backend/executor/nodeValuesscan.c b/src/backend/executor/nodeValuesscan.c
@@ -285,7 +285,7 @@ ExecInitValuesScan(ValuesScan *node, EState *estate, int eflags)
 	i = 0;
 	foreach(vtl, node->values_lists)
 	{
-		List	   *exprs = castNode(List, lfirst(vtl));
+		List	   *exprs = lfirst_node(List, vtl);
 
 		scanstate->exprlists[i] = exprs;
 
diff --git a/src/backend/optimizer/util/paramassign.c b/src/backend/optimizer/util/paramassign.c
@@ -431,7 +431,7 @@ process_subquery_nestloop_params(PlannerInfo *root, List *subplan_params)
 
 	foreach(lc, subplan_params)
 	{
-		PlannerParamItem *pitem = castNode(PlannerParamItem, lfirst(lc));
+		PlannerParamItem *pitem = lfirst_node(PlannerParamItem, lc);
 
 		if (IsA(pitem->item, Var))
 		{
diff --git a/src/backend/parser/parse_clause.c b/src/backend/parser/parse_clause.c
@@ -2807,7 +2807,7 @@ transformWindowDefinitions(ParseState *pstate,
 						(errcode(ERRCODE_WINDOWING_ERROR),
 						 errmsg("RANGE with offset PRECEDING/FOLLOWING requires exactly one ORDER BY column"),
 						 parser_errposition(pstate, windef->location)));
-			sortcl = castNode(SortGroupClause, linitial(wc->orderClause));
+			sortcl = linitial_node(SortGroupClause, wc->orderClause);
 			sortkey = get_sortgroupclause_expr(sortcl, *targetlist);
 			/* Find the sort operator in pg_amop */
 			if (!get_ordering_op_properties(sortcl->sortop,
diff --git a/src/backend/parser/parse_utilcmd.c b/src/backend/parser/parse_utilcmd.c
@@ -2424,7 +2424,7 @@ transformIndexConstraint(Constraint *constraint, CreateStmtContext *cxt)
 			/* Make sure referenced column exists. */
 			foreach(columns, cxt->columns)
 			{
-				column = castNode(ColumnDef, lfirst(columns));
+				column = lfirst_node(ColumnDef, columns);
 				if (strcmp(column->colname, key) == 0)
 				{
 					found = true;
@@ -2462,7 +2462,7 @@ transformIndexConstraint(Constraint *constraint, CreateStmtContext *cxt)
 
 				foreach(inher, cxt->inhRelations)
 				{
-					RangeVar   *inh = castNode(RangeVar, lfirst(inher));
+					RangeVar   *inh = lfirst_node(RangeVar, inher);
 					Relation	rel;
 					int			count;
 
@@ -4088,7 +4088,7 @@ transformPartitionBound(ParseState *pstate, Relation parent,
 			duplicate = false;
 			foreach(cell2, result_spec->listdatums)
 			{
-				Const	   *value2 = castNode(Const, lfirst(cell2));
+				Const	   *value2 = lfirst_node(Const, cell2);
 
 				if (equal(value, value2))
 				{
@@ -4267,7 +4267,7 @@ validateInfiniteBounds(ParseState *pstate, List *blist)
 
 	foreach(lc, blist)
 	{
-		PartitionRangeDatum *prd = castNode(PartitionRangeDatum, lfirst(lc));
+		PartitionRangeDatum *prd = lfirst_node(PartitionRangeDatum, lc);
 
 		if (kind == prd->kind)
 			continue;
diff --git a/src/backend/partitioning/partbounds.c b/src/backend/partitioning/partbounds.c
@@ -452,7 +452,7 @@ get_non_null_list_datum_count(PartitionBoundSpec **boundspecs, int nparts)
 
 		foreach(lc, boundspecs[i]->listdatums)
 		{
-			Const	   *val = castNode(Const, lfirst(lc));
+			Const	   *val = lfirst_node(Const, lc);
 
 			if (!val->constisnull)
 				count++;
@@ -513,7 +513,7 @@ create_list_bounds(PartitionBoundSpec **boundspecs, int nparts,
 
 		foreach(c, spec->listdatums)
 		{
-			Const	   *val = castNode(Const, lfirst(c));
+			Const	   *val = lfirst_node(Const, c);
 
 			if (!val->constisnull)
 			{
@@ -3014,7 +3014,7 @@ check_new_partition_bound(char *relname, Relation parent,
 
 					foreach(cell, spec->listdatums)
 					{
-						Const	   *val = castNode(Const, lfirst(cell));
+						Const	   *val = lfirst_node(Const, cell);
 
 						overlap_location = val->location;
 						if (!val->constisnull)
@@ -3399,7 +3399,7 @@ make_one_partition_rbound(PartitionKey key, int index, List *datums, bool lower)
 	i = 0;
 	foreach(lc, datums)
 	{
-		PartitionRangeDatum *datum = castNode(PartitionRangeDatum, lfirst(lc));
+		PartitionRangeDatum *datum = lfirst_node(PartitionRangeDatum, lc);
 
 		/* What's contained in this range datum? */
 		bound->kind[i] = datum->kind;
@@ -4103,7 +4103,7 @@ get_qual_for_list(Relation parent, PartitionBoundSpec *spec)
 		 */
 		foreach(cell, spec->listdatums)
 		{
-			Const	   *val = castNode(Const, lfirst(cell));
+			Const	   *val = lfirst_node(Const, cell);
 
 			if (val->constisnull)
 				list_has_null = true;
@@ -4358,8 +4358,8 @@ get_qual_for_range(Relation parent, PartitionBoundSpec *spec,
 		Datum		test_result;
 		bool		isNull;
 
-		ldatum = castNode(PartitionRangeDatum, lfirst(cell1));
-		udatum = castNode(PartitionRangeDatum, lfirst(cell2));
+		ldatum = lfirst_node(PartitionRangeDatum, cell1);
+		udatum = lfirst_node(PartitionRangeDatum, cell2);
 
 		/*
 		 * Since get_range_key_properties() modifies partexprs_item, and we
@@ -4440,11 +4440,11 @@ get_qual_for_range(Relation parent, PartitionBoundSpec *spec,
 			PartitionRangeDatum *ldatum_next = NULL,
 					   *udatum_next = NULL;
 
-			ldatum = castNode(PartitionRangeDatum, lfirst(cell1));
+			ldatum = lfirst_node(PartitionRangeDatum, cell1);
 			if (lnext(spec->lowerdatums, cell1))
 				ldatum_next = castNode(PartitionRangeDatum,
 									   lfirst(lnext(spec->lowerdatums, cell1)));
-			udatum = castNode(PartitionRangeDatum, lfirst(cell2));
+			udatum = lfirst_node(PartitionRangeDatum, cell2);
 			if (lnext(spec->upperdatums, cell2))
 				udatum_next = castNode(PartitionRangeDatum,
 									   lfirst(lnext(spec->upperdatums, cell2)));
diff --git a/src/backend/rewrite/rewriteSearchCycle.c b/src/backend/rewrite/rewriteSearchCycle.c
@@ -307,8 +307,8 @@ rewriteSearchAndCycle(CommonTableExpr *cte)
 					  list_nth_oid(cte->ctecolcollations, i),
 					  0);
 		tle = makeTargetEntry((Expr *) var, i + 1, strVal(list_nth(cte->ctecolnames, i)), false);
-		tle->resorigtbl = castNode(TargetEntry, list_nth(rte1->subquery->targetList, i))->resorigtbl;
-		tle->resorigcol = castNode(TargetEntry, list_nth(rte1->subquery->targetList, i))->resorigcol;
+		tle->resorigtbl = list_nth_node(TargetEntry, rte1->subquery->targetList, i)->resorigtbl;
+		tle->resorigcol = list_nth_node(TargetEntry, rte1->subquery->targetList, i)->resorigcol;
 		newq1->targetList = lappend(newq1->targetList, tle);
 	}
 
@@ -482,8 +482,8 @@ rewriteSearchAndCycle(CommonTableExpr *cte)
 					  list_nth_oid(cte->ctecolcollations, i),
 					  0);
 		tle = makeTargetEntry((Expr *) var, i + 1, strVal(list_nth(cte->ctecolnames, i)), false);
-		tle->resorigtbl = castNode(TargetEntry, list_nth(rte2->subquery->targetList, i))->resorigtbl;
-		tle->resorigcol = castNode(TargetEntry, list_nth(rte2->subquery->targetList, i))->resorigcol;
+		tle->resorigtbl = list_nth_node(TargetEntry, rte2->subquery->targetList, i)->resorigtbl;
+		tle->resorigcol = list_nth_node(TargetEntry, rte2->subquery->targetList, i)->resorigcol;
 		newq2->targetList = lappend(newq2->targetList, tle);
 	}
 
diff --git a/src/backend/tcop/postgres.c b/src/backend/tcop/postgres.c
@@ -785,7 +785,7 @@ pg_rewrite_query(Query *query)
 		 */
 		foreach(lc, querytree_list)
 		{
-			Query	   *query = castNode(Query, lfirst(lc));
+			Query	   *query = lfirst_node(Query, lc);
 
 			if (query->commandType != CMD_UTILITY)
 			{
diff --git a/src/backend/utils/adt/ruleutils.c b/src/backend/utils/adt/ruleutils.c
@@ -7793,7 +7793,7 @@ find_param_referent(Param *param, deparse_context *context,
 			 */
 			foreach(lc2, ((Plan *) ancestor)->initPlan)
 			{
-				SubPlan    *subplan = castNode(SubPlan, lfirst(lc2));
+				SubPlan    *subplan = lfirst_node(SubPlan, lc2);
 
 				if (child_plan != (Plan *) list_nth(dpns->subplans,
 													subplan->plan_id - 1))
@@ -9407,7 +9407,7 @@ get_rule_expr(Node *node, deparse_context *context,
 						sep = "";
 						foreach(cell, spec->listdatums)
 						{
-							Const	   *val = castNode(Const, lfirst(cell));
+							Const	   *val = lfirst_node(Const, cell);
 
 							appendStringInfoString(buf, sep);
 							get_const_expr(val, context, -1);
@@ -11990,7 +11990,7 @@ get_range_partbound_string(List *bound_datums)
 	foreach(cell, bound_datums)
 	{
 		PartitionRangeDatum *datum =
-		castNode(PartitionRangeDatum, lfirst(cell));
+		lfirst_node(PartitionRangeDatum, cell);
 
 		appendStringInfoString(buf, sep);
 		if (datum->kind == PARTITION_RANGE_DATUM_MINVALUE)
diff --git a/src/pl/plpgsql/src/pl_exec.c b/src/pl/plpgsql/src/pl_exec.c
@@ -7996,7 +7996,7 @@ exec_save_simple_expr(PLpgSQL_expr *expr, CachedPlan *cplan)
 	{
 		/* Extract the single tlist expression */
 		Assert(list_length(plan->targetlist) == 1);
-		tle_expr = castNode(TargetEntry, linitial(plan->targetlist))->expr;
+		tle_expr = linitial_node(TargetEntry, plan->targetlist)->expr;
 
 		if (IsA(plan, Result))
 		{
diff --git a/src/test/modules/test_predtest/test_predtest.c b/src/test/modules/test_predtest/test_predtest.c
@@ -131,8 +131,8 @@ test_predtest(PG_FUNCTION_ARGS)
 		elog(ERROR, "failed to decipher query plan");
 	plan = stmt->planTree;
 	Assert(list_length(plan->targetlist) >= 2);
-	clause1 = castNode(TargetEntry, linitial(plan->targetlist))->expr;
-	clause2 = castNode(TargetEntry, lsecond(plan->targetlist))->expr;
+	clause1 = linitial_node(TargetEntry, plan->targetlist)->expr;
+	clause2 = lsecond_node(TargetEntry, plan->targetlist)->expr;
 
 	/*
 	 * Because the clauses are in the SELECT list, preprocess_expression did

Original file line number	Diff line number	Diff line change
`@@ -514,7 +514,7 @@ OpenTableList(List *tables)`
`514`	`514`	`*/`
`515`	`515`	`foreach(lc, tables)`
`516`	`516`	`{`
`517`		`- RangeVar *rv = castNode(RangeVar, lfirst(lc));`
	`517`	`+ RangeVar *rv = lfirst_node(RangeVar, lc);`
`518`	`518`	`bool recurse = rv->inh;`
`519`	`519`	`Relation rel;`
`520`	`520`	`Oid myrelid;`
Original file line number	Diff line number	Diff line change
`@@ -4770,7 +4770,7 @@ ATRewriteCatalogs(List **wqueue, LOCKMODE lockmode,`
`4770`	`4770`
`4771`	`4771`	`foreach(lcmd, subcmds)`
`4772`	`4772`	`ATExecCmd(wqueue, tab,`
`4773`		`- castNode(AlterTableCmd, lfirst(lcmd)),`
	`4773`	`+ lfirst_node(AlterTableCmd, lcmd),`
`4774`	`4774`	`lockmode, pass, context);`
`4775`	`4775`
`4776`	`4776`	`/*`
`@@ -12842,7 +12842,7 @@ ATPostAlterTypeParse(Oid oldId, Oid oldRelId, Oid refRelId, char *cmd,`
`12842`	`12842`
`12843`	`12843`	`foreach(lcmd, stmt->cmds)`
`12844`	`12844`	`{`
`12845`		`- AlterTableCmd *cmd = castNode(AlterTableCmd, lfirst(lcmd));`
	`12845`	`+ AlterTableCmd *cmd = lfirst_node(AlterTableCmd, lcmd);`
`12846`	`12846`
`12847`	`12847`	`if (cmd->subtype == AT_AddIndex)`
`12848`	`12848`	`{`
`@@ -16671,7 +16671,7 @@ transformPartitionSpec(Relation rel, PartitionSpec partspec, char strategy)`
`16671`	`16671`	`/* take care of any partition expressions */`
`16672`	`16672`	`foreach(l, partspec->partParams)`
`16673`	`16673`	`{`
`16674`		`- PartitionElem *pelem = castNode(PartitionElem, lfirst(l));`
	`16674`	`+ PartitionElem *pelem = lfirst_node(PartitionElem, l);`
`16675`	`16675`
`16676`	`16676`	`if (pelem->expr)`
`16677`	`16677`	`{`
`@@ -16708,7 +16708,7 @@ ComputePartitionAttrs(ParseState pstate, Relation rel, List partParams, AttrNu`
`16708`	`16708`	`attn = 0;`
`16709`	`16709`	`foreach(lc, partParams)`
`16710`	`16710`	`{`
`16711`		`- PartitionElem *pelem = castNode(PartitionElem, lfirst(lc));`
	`16711`	`+ PartitionElem *pelem = lfirst_node(PartitionElem, lc);`
`16712`	`16712`	`Oid atttype;`
`16713`	`16713`	`Oid attcollation;`
`16714`	`16714`
Original file line number	Diff line number	Diff line change
`@@ -585,7 +585,7 @@ ExecInitPartitionInfo(ModifyTableState mtstate, EState estate,`
`585`	`585`
`586`	`586`	`foreach(ll, wcoList)`
`587`	`587`	`{`
`588`		`- WithCheckOption *wco = castNode(WithCheckOption, lfirst(ll));`
	`588`	`+ WithCheckOption *wco = lfirst_node(WithCheckOption, ll);`
`589`	`589`	`ExprState *wcoExpr = ExecInitQual(castNode(List, wco->qual),`
`590`	`590`	`&mtstate->ps);`
`591`	`591`
Original file line number	Diff line number	Diff line change
`@@ -285,7 +285,7 @@ ExecInitValuesScan(ValuesScan node, EState estate, int eflags)`
`285`	`285`	`i = 0;`
`286`	`286`	`foreach(vtl, node->values_lists)`
`287`	`287`	`{`
`288`		`- List *exprs = castNode(List, lfirst(vtl));`
	`288`	`+ List *exprs = lfirst_node(List, vtl);`
`289`	`289`
`290`	`290`	`scanstate->exprlists[i] = exprs;`
`291`	`291`
Original file line number	Diff line number	Diff line change
`@@ -431,7 +431,7 @@ process_subquery_nestloop_params(PlannerInfo root, List subplan_params)`
`431`	`431`
`432`	`432`	`foreach(lc, subplan_params)`
`433`	`433`	`{`
`434`		`- PlannerParamItem *pitem = castNode(PlannerParamItem, lfirst(lc));`
	`434`	`+ PlannerParamItem *pitem = lfirst_node(PlannerParamItem, lc);`
`435`	`435`
`436`	`436`	`if (IsA(pitem->item, Var))`
`437`	`437`	`{`
Original file line number	Diff line number	Diff line change
`@@ -2424,7 +2424,7 @@ transformIndexConstraint(Constraint constraint, CreateStmtContext cxt)`
`2424`	`2424`	`/* Make sure referenced column exists. */`
`2425`	`2425`	`foreach(columns, cxt->columns)`
`2426`	`2426`	`{`
`2427`		`- column = castNode(ColumnDef, lfirst(columns));`
	`2427`	`+ column = lfirst_node(ColumnDef, columns);`
`2428`	`2428`	`if (strcmp(column->colname, key) == 0)`
`2429`	`2429`	`{`
`2430`	`2430`	`found = true;`
`@@ -2462,7 +2462,7 @@ transformIndexConstraint(Constraint constraint, CreateStmtContext cxt)`
`2462`	`2462`
`2463`	`2463`	`foreach(inher, cxt->inhRelations)`
`2464`	`2464`	`{`
`2465`		`- RangeVar *inh = castNode(RangeVar, lfirst(inher));`
	`2465`	`+ RangeVar *inh = lfirst_node(RangeVar, inher);`
`2466`	`2466`	`Relation rel;`
`2467`	`2467`	`int count;`
`2468`	`2468`
`@@ -4088,7 +4088,7 @@ transformPartitionBound(ParseState *pstate, Relation parent,`
`4088`	`4088`	`duplicate = false;`
`4089`	`4089`	`foreach(cell2, result_spec->listdatums)`
`4090`	`4090`	`{`
`4091`		`- Const *value2 = castNode(Const, lfirst(cell2));`
	`4091`	`+ Const *value2 = lfirst_node(Const, cell2);`
`4092`	`4092`
`4093`	`4093`	`if (equal(value, value2))`
`4094`	`4094`	`{`
`@@ -4267,7 +4267,7 @@ validateInfiniteBounds(ParseState pstate, List blist)`
`4267`	`4267`
`4268`	`4268`	`foreach(lc, blist)`
`4269`	`4269`	`{`
`4270`		`- PartitionRangeDatum *prd = castNode(PartitionRangeDatum, lfirst(lc));`
	`4270`	`+ PartitionRangeDatum *prd = lfirst_node(PartitionRangeDatum, lc);`
`4271`	`4271`
`4272`	`4272`	`if (kind == prd->kind)`
`4273`	`4273`	`continue;`
Original file line number	Diff line number	Diff line change
`@@ -785,7 +785,7 @@ pg_rewrite_query(Query *query)`
`785`	`785`	`*/`
`786`	`786`	`foreach(lc, querytree_list)`
`787`	`787`	`{`
`788`		`- Query *query = castNode(Query, lfirst(lc));`
	`788`	`+ Query *query = lfirst_node(Query, lc);`
`789`	`789`
`790`	`790`	`if (query->commandType != CMD_UTILITY)`
`791`	`791`	`{`