Apply patch for test_fsync to add tests for O_DIRECT.

bmomjian · bmomjian · commit 677b06ca462e · 2011-01-15T11:55:13.000-05:00
Adjusted patch by Josh Berkus
diff --git a/src/tools/fsync/Makefile b/src/tools/fsync/Makefile
@@ -16,9 +16,9 @@ override CPPFLAGS := -I$(libpq_srcdir) $(CPPFLAGS)
 
 OBJS= test_fsync.o
 
-all: test_fsync
+all: submake-libpq submake-libpgport test_fsync
 
-test_fsync: test_fsync.o | submake-libpq submake-libpgport
+test_fsync: test_fsync.o $(libpq_builddir)/libpq.a
 	$(CC) $(CFLAGS) test_fsync.o $(libpq_pgport) $(LDFLAGS) $(LDFLAGS_EX) $(LIBS) -o $@$(X)
 
 clean distclean maintainer-clean:
diff --git a/src/tools/fsync/README b/src/tools/fsync/README
@@ -1,11 +1,20 @@
-src/tools/fsync/README
-
-fsync
-=====
+test_fsync
+==========
 
 This program tests fsync.  The tests are described as part of the program output.
 
 	Usage:	test_fsync [-f filename] [loops]
+	
+test_fsync is intended to give you a reasonable idea of what the fastest
+fsync_method is on your specific system, as well as supplying diagnostic
+information in the event of an identified I/O problem.  However,
+differences shown by test_fsync might not make any difference in real
+database throughput, especially since many database servers are not
+speed-limited by their transaction logs.
+
+The output filename defaults to test_fsync.out in the current directory.
+test_fsync should be run in the same filesystem as your transaction log
+directory (pg_xlog).
+
+Loops default to 2000.  Increase this to get more accurate measurements.
 
-Loops defaults to 5000.  The default output file is /var/tmp/test_fsync.out.
-Consider that /tmp or /var/tmp might be memory-based file systems.
diff --git a/src/tools/fsync/test_fsync.c b/src/tools/fsync/test_fsync.c
