Fix portability issues with stddev in pg_stat_statements

adunstan · adunstan · commit 735cd6128a6a · 2015-03-27T17:29:59.000-04:00
Stddev is calculated on the fly, and the code in commit 717f709 was using Float8GetDatumFast() inappropriately to convert the result to a Datum. Mea culpa. It now uses Float8GetDatum().
diff --git a/contrib/pg_stat_statements/pg_stat_statements.c b/contrib/pg_stat_statements/pg_stat_statements.c
@@ -1577,12 +1577,15 @@ pg_stat_statements_internal(FunctionCallInfo fcinfo,
 			 * sample variance, as we have data for the whole population,
 			 * so Bessel's correction is not used, and we don't divide by
 			 * tmp.calls - 1.
+			 *
+			 * We're calculating the stddev on the fly, so it's not in the tmp
+			 * structure, so we can't use the Float8GetDatumFast macro here.
 			 */
 			if (tmp.calls > 1)
 				values[i++] =
-					Float8GetDatumFast(sqrtd(tmp.sum_var_time / tmp.calls));
+					Float8GetDatum(sqrtd(tmp.sum_var_time / tmp.calls));
 			else
-				values[i++] = Float8GetDatumFast(0.0);
+				values[i++] = Float8GetDatum(0.0);
 		}
 		values[i++] = Int64GetDatumFast(tmp.rows);
 		values[i++] = Int64GetDatumFast(tmp.shared_blks_hit);
