Fix pg_dumpall to restore its ability to dump from ancient servers.

tglsfdc · tglsfdc · commit 79b2fa5bd2f7 · 2014-11-13T18:19:38.000-05:00
Fix breakage induced by commits d8d3d2a and 463f262: pg_dumpall has crashed when attempting to dump from pre-8.1 servers since then, due to faulty construction of the query used for dumping roles from older servers. The query was erroneous as of the earlier commit, but it wasn't exposed unless you tried to use --binary-upgrade, which you presumably wouldn't with a pre-8.1 server. However commit 463f262 made it fail always. In HEAD, also fix additional breakage induced in the same query by commit 491c029, which evidently wasn't tested against pre-8.1 servers either. The bug is only latent in 9.1 because 463f262 hadn't landed yet, but it seems best to back-patch all branches containing the faulty query. Gilles Darold
diff --git a/src/bin/pg_dump/pg_dumpall.c b/src/bin/pg_dump/pg_dumpall.c
@@ -672,7 +672,7 @@ dumpRoles(PGconn *conn)
 						  "ORDER BY 2");
 	else
 		printfPQExpBuffer(buf,
-						  "SELECT 0, usename as rolname, "
+						  "SELECT 0 as oid, usename as rolname, "
 						  "usesuper as rolsuper, "
 						  "true as rolinherit, "
 						  "usesuper as rolcreaterole, "
@@ -685,7 +685,7 @@ dumpRoles(PGconn *conn)
 						  "null as rolcomment "
 						  "FROM pg_shadow "
 						  "UNION ALL "
-						  "SELECT 0, groname as rolname, "
+						  "SELECT 0 as oid, groname as rolname, "
 						  "false as rolsuper, "
 						  "true as rolinherit, "
 						  "false as rolcreaterole, "
