Fix failure to double-quote function argument names when needed, in

tglsfdc · tglsfdc · commit adaf60131f81 · 2009-06-09T14:36:06.000Z
pg_get_function_arguments() and related functions.  Per report from
Andreas Nolte.
diff --git a/src/backend/utils/adt/ruleutils.c b/src/backend/utils/adt/ruleutils.c
@@ -9,7 +9,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/utils/adt/ruleutils.c,v 1.298 2009/05/26 17:36:05 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/utils/adt/ruleutils.c,v 1.299 2009/06/09 14:36:06 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1832,7 +1832,7 @@ print_function_arguments(StringInfo buf, HeapTuple proctup,
 			appendStringInfoString(buf, ", ");
 		appendStringInfoString(buf, modename);
 		if (argname && argname[0])
-			appendStringInfo(buf, "%s ", argname);
+			appendStringInfo(buf, "%s ", quote_identifier(argname));
 		appendStringInfoString(buf, format_type_be(argtype));
 		if (print_defaults && isinput && inputargno > nlackdefaults)
 		{

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`*`
`10`	`10`	`*`
`11`	`11`	`* IDENTIFICATION`
`12`		`- * $PostgreSQL: pgsql/src/backend/utils/adt/ruleutils.c,v 1.298 2009/05/26 17:36:05 tgl Exp $`
	`12`	`+ * $PostgreSQL: pgsql/src/backend/utils/adt/ruleutils.c,v 1.299 2009/06/09 14:36:06 tgl Exp $`
`13`	`13`	`*`
`14`	`14`	`*-------------------------------------------------------------------------`
`15`	`15`	`*/`
`@@ -1832,7 +1832,7 @@ print_function_arguments(StringInfo buf, HeapTuple proctup,`
`1832`	`1832`	`appendStringInfoString(buf, ", ");`
`1833`	`1833`	`appendStringInfoString(buf, modename);`
`1834`	`1834`	`if (argname && argname[0])`
`1835`		`- appendStringInfo(buf, "%s ", argname);`
	`1835`	`+ appendStringInfo(buf, "%s ", quote_identifier(argname));`
`1836`	`1836`	`appendStringInfoString(buf, format_type_be(argtype));`
`1837`	`1837`	`if (print_defaults && isinput && inputargno > nlackdefaults)`
`1838`	`1838`	`{`