Skip to content

Commit ae667f7

Browse files
committed
Really fix compilation failure on MIPS.
I missed an additional colon in previous patch. Oops. to make that mistake less likely in the future, add comments as placeholders for unused inputs and outputs in inline assembly.
1 parent baf7b3a commit ae667f7

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

src/include/storage/s_lock.h

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ tas(volatile slock_t *lock)
158158
" xchgb %0,%1 \n"
159159
"1: \n"
160160
: "+q"(_res), "+m"(*lock)
161-
:
161+
: /* no inputs */
162162
: "memory", "cc");
163163
return (int) _res;
164164
}
@@ -225,7 +225,7 @@ tas(volatile slock_t *lock)
225225
" lock \n"
226226
" xchgb %0,%1 \n"
227227
: "+q"(_res), "+m"(*lock)
228-
:
228+
: /* no inputs */
229229
: "memory", "cc");
230230
return (int) _res;
231231
}
@@ -519,7 +519,7 @@ tas(volatile slock_t *lock)
519519
" tas %1 \n"
520520
" sne %0 \n"
521521
: "=d"(rv), "+m"(*lock)
522-
:
522+
: /* no inputs */
523523
: "memory", "cc");
524524
return rv;
525525
}
@@ -586,7 +586,7 @@ tas(volatile slock_t *lock)
586586
" sync \n"
587587
" .set pop "
588588
: "=&r" (_res), "=&r" (_tmp), "+R" (*_l)
589-
:
589+
: /* no inputs */
590590
: "memory");
591591
return _res;
592592
}
@@ -602,7 +602,8 @@ do \
602602
" .set nomacro \n" \
603603
" sync \n" \
604604
" .set pop " \
605-
: \
605+
: /* no outputs */ \
606+
: /* no inputs */ \
606607
: "memory"); \
607608
*((volatile slock_t *) (lock)) = 0; \
608609
} while (0)

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy