Skip to content

Commit b2b2491

Browse files
committed
Don't test xmin/xmax columns of a postgres_fdw foreign table.
Their values are unspecified and system-dependent. Per buildfarm member kouprey.
1 parent 7cbe57c commit b2b2491

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

contrib/postgres_fdw/expected/postgres_fdw.out

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2804,14 +2804,14 @@ NOTICE: trig_row_before(23, skidoo) BEFORE ROW UPDATE ON rem1
28042804
NOTICE: OLD: (12,"test triggered !"),NEW: (12,testo)
28052805
NOTICE: trig_row_after(23, skidoo) AFTER ROW UPDATE ON rem1
28062806
NOTICE: OLD: (12,"test triggered !"),NEW: (12,"testo triggered !")
2807-
-- Test returning system attributes
2808-
INSERT INTO rem1(f2) VALUES ('test') RETURNING ctid, xmin, xmax;
2807+
-- Test returning a system attribute
2808+
INSERT INTO rem1(f2) VALUES ('test') RETURNING ctid;
28092809
NOTICE: trig_row_before(23, skidoo) BEFORE ROW INSERT ON rem1
28102810
NOTICE: NEW: (13,test)
28112811
NOTICE: trig_row_after(23, skidoo) AFTER ROW INSERT ON rem1
28122812
NOTICE: NEW: (13,"test triggered !")
2813-
ctid | xmin | xmax
2814-
--------+------+------------
2815-
(0,27) | 180 | 4294967295
2813+
ctid
2814+
--------
2815+
(0,27)
28162816
(1 row)
28172817

contrib/postgres_fdw/sql/postgres_fdw.sql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -604,5 +604,5 @@ FOR EACH ROW EXECUTE PROCEDURE trig_row_before_insupdate();
604604
INSERT INTO rem1(f2) VALUES ('test');
605605
UPDATE rem1 SET f2 = 'testo';
606606

607-
-- Test returning system attributes
608-
INSERT INTO rem1(f2) VALUES ('test') RETURNING ctid, xmin, xmax;
607+
-- Test returning a system attribute
608+
INSERT INTO rem1(f2) VALUES ('test') RETURNING ctid;

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy