Fix a bunch of functions that were declared static then defined not-static.

tglsfdc · tglsfdc · commit c1907f0cc49e · 2014-05-17T17:57:53.000-04:00
Per testing with a compiler that whines about this.
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
@@ -8318,7 +8318,7 @@ CreateCheckPoint(int flags)
  * CreateRestartPoint() allows for the case where recovery may end before
  * the restartpoint completes so there is no concern of concurrent behaviour.
  */
-void
+static void
 CreateEndOfRecoveryRecord(void)
 {
 	xl_end_of_recovery xlrec;
diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication/logical/reorderbuffer.c
@@ -322,7 +322,7 @@ ReorderBufferGetTXN(ReorderBuffer *rb)
  * Deallocation might be delayed for efficiency purposes, for details check
  * the comments above max_cached_changes's definition.
  */
-void
+static void
 ReorderBufferReturnTXN(ReorderBuffer *rb, ReorderBufferTXN *txn)
 {
 	/* clean the lookup cache if we were cached (quite likely) */
diff --git a/src/backend/utils/cache/relcache.c b/src/backend/utils/cache/relcache.c
@@ -2381,7 +2381,7 @@ RelationCloseSmgrByOid(Oid relationId)
 	RelationCloseSmgr(relation);
 }
 
-void
+static void
 RememberToFreeTupleDescAtEOX(TupleDesc td)
 {
 	if (EOXactTupleDescArray == NULL)
diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
@@ -5340,7 +5340,7 @@ config_enum_get_options(struct config_enum * record, const char *prefix,
  *	1: the value is valid
  *	0: the name or value is invalid
  */
-bool
+static bool
 validate_conf_option(struct config_generic * record, const char *name,
 					 const char *value, GucSource source, int elevel,
 					 bool freemem, void *newval, void **newextra)
diff --git a/src/bin/pg_ctl/pg_ctl.c b/src/bin/pg_ctl/pg_ctl.c
@@ -399,7 +399,7 @@ readfile(const char *path)
 /*
  * Free memory allocated for optlines through readfile()
  */
-void
+static void
 free_readfile(char **optlines)
 {
 	char	   *curr_line = NULL;

Original file line number	Diff line number	Diff line change
`@@ -8318,7 +8318,7 @@ CreateCheckPoint(int flags)`
`8318`	`8318`	`* CreateRestartPoint() allows for the case where recovery may end before`
`8319`	`8319`	`* the restartpoint completes so there is no concern of concurrent behaviour.`
`8320`	`8320`	`*/`
`8321`		`-void`
	`8321`	`+static void`
`8322`	`8322`	`CreateEndOfRecoveryRecord(void)`
`8323`	`8323`	`{`
`8324`	`8324`	`xl_end_of_recovery xlrec;`
Original file line number	Diff line number	Diff line change
`@@ -322,7 +322,7 @@ ReorderBufferGetTXN(ReorderBuffer *rb)`
`322`	`322`	`* Deallocation might be delayed for efficiency purposes, for details check`
`323`	`323`	`* the comments above max_cached_changes's definition.`
`324`	`324`	`*/`
`325`		`-void`
	`325`	`+static void`
`326`	`326`	`ReorderBufferReturnTXN(ReorderBuffer rb, ReorderBufferTXN txn)`
`327`	`327`	`{`
`328`	`328`	`/* clean the lookup cache if we were cached (quite likely) */`
Original file line number	Diff line number	Diff line change
`@@ -2381,7 +2381,7 @@ RelationCloseSmgrByOid(Oid relationId)`
`2381`	`2381`	`RelationCloseSmgr(relation);`
`2382`	`2382`	`}`
`2383`	`2383`
`2384`		`-void`
	`2384`	`+static void`
`2385`	`2385`	`RememberToFreeTupleDescAtEOX(TupleDesc td)`
`2386`	`2386`	`{`
`2387`	`2387`	`if (EOXactTupleDescArray == NULL)`
Original file line number	Diff line number	Diff line change
`@@ -399,7 +399,7 @@ readfile(const char *path)`
`399`	`399`	`/*`
`400`	`400`	`* Free memory allocated for optlines through readfile()`
`401`	`401`	`*/`
`402`		`-void`
	`402`	`+static void`
`403`	`403`	`free_readfile(char **optlines)`
`404`	`404`	`{`
`405`	`405`	`char *curr_line = NULL;`