Fix ERROR message in injection_point.c

michaelpq · michaelpq · commit cdd863480c27 · 2024-01-23T10:45:00.000+09:00
This commit fixes an error message that failed to show the correct function and library names when a function cannot be loaded. While on it, adjust the call to load_external_function() so as this ERROR can be reached, by making load_external_function() return NULL rather than fail if a function cannot be found for a given injection point. Thinkos in d86d20f.
diff --git a/src/backend/utils/misc/injection_point.c b/src/backend/utils/misc/injection_point.c
@@ -300,11 +300,11 @@ InjectionPointRun(const char *name)
 				 path, name);
 
 		injection_callback = (InjectionPointCallback)
-			load_external_function(path, entry_by_name->function, true, NULL);
+			load_external_function(path, entry_by_name->function, false, NULL);
 
 		if (injection_callback == NULL)
 			elog(ERROR, "could not find function \"%s\" in library \"%s\" for injection point \"%s\"",
-				 name, entry_by_name->function, path);
+				 entry_by_name->function, path, name);
 
 		/* add it to the local cache when found */
 		injection_point_cache_add(name, injection_callback);
