Fix use-after-ReleaseSysCache problem in ATExecAlterColumnType.

robertmhaas · robertmhaas · commit d00fbdc43119 · 2021-03-19T17:17:48.000-04:00
Introduced by commit bbe0a81. Per buildfarm member prion.
diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
@@ -11953,8 +11953,6 @@ ATExecAlterColumnType(AlteredTableInfo *tab, Relation rel,
 	attTup->attalign = tform->typalign;
 	attTup->attstorage = tform->typstorage;
 
-	ReleaseSysCache(typeTuple);
-
 	/* Setup attribute compression */
 	if (rel->rd_rel->relkind == RELKIND_RELATION ||
 		rel->rd_rel->relkind == RELKIND_PARTITIONED_TABLE)
@@ -11972,6 +11970,8 @@ ATExecAlterColumnType(AlteredTableInfo *tab, Relation rel,
 	else
 		attTup->attcompression = InvalidCompressionMethod;
 
+	ReleaseSysCache(typeTuple);
+
 	CatalogTupleUpdate(attrelation, &heapTup->t_self, heapTup);
 
 	table_close(attrelation, RowExclusiveLock);
