Correct replication origin's use of UINT16_MAX to PG_UINT16_MAX.

anarazel · anarazel · commit e0f26fc76532 · 2015-04-30T00:19:36.000+02:00
We can't rely on UINT16_MAX being present, which is why we introduced
PG_UINT16_MAX...

Buildfarm animal bowerbird via Andrew Gierth.
diff --git a/src/backend/replication/logical/origin.c b/src/backend/replication/logical/origin.c
@@ -266,7 +266,7 @@ replorigin_create(char *roname)
 
 	rel = heap_open(ReplicationOriginRelationId, ExclusiveLock);
 
-	for (roident = InvalidOid + 1; roident < UINT16_MAX; roident++)
+	for (roident = InvalidOid + 1; roident < PG_UINT16_MAX; roident++)
 	{
 		bool		nulls[Natts_pg_replication_origin];
 		Datum		values[Natts_pg_replication_origin];
diff --git a/src/include/replication/origin.h b/src/include/replication/origin.h
@@ -30,7 +30,7 @@ typedef struct xl_replorigin_drop
 #define XLOG_REPLORIGIN_DROP		0x10
 
 #define InvalidRepOriginId 0
-#define DoNotReplicateId UINT16_MAX
+#define DoNotReplicateId PG_UINT16_MAX
 
 extern PGDLLIMPORT RepOriginId replorigin_sesssion_origin;
 extern PGDLLIMPORT XLogRecPtr replorigin_sesssion_origin_lsn;

Original file line number	Diff line number	Diff line change
`@@ -266,7 +266,7 @@ replorigin_create(char *roname)`
`266`	`266`
`267`	`267`	`rel = heap_open(ReplicationOriginRelationId, ExclusiveLock);`
`268`	`268`
`269`		`- for (roident = InvalidOid + 1; roident < UINT16_MAX; roident++)`
	`269`	`+ for (roident = InvalidOid + 1; roident < PG_UINT16_MAX; roident++)`
`270`	`270`	`{`
`271`	`271`	`bool nulls[Natts_pg_replication_origin];`
`272`	`272`	`Datum values[Natts_pg_replication_origin];`