Mark misc static global variables as const

hlinnaka · hlinnaka · commit fe8dd65bf28d · 2024-08-06T23:04:48.000+03:00
Reviewed-by: Andres Freund Discussion: https://www.postgresql.org/message-id/54c29fb0-edf2-48ea-9814-44e918bbd6e8@iki.fi
diff --git a/contrib/btree_gist/btree_interval.c b/contrib/btree_gist/btree_interval.c
@@ -113,7 +113,7 @@ static const gbtree_ninfo tinfo =
 Interval *
 abs_interval(Interval *a)
 {
-	static Interval zero = {0, 0, 0};
+	static const Interval zero = {0, 0, 0};
 
 	if (DatumGetBool(DirectFunctionCall2(interval_lt,
 										 IntervalPGetDatum(a),
diff --git a/contrib/oid2name/oid2name.c b/contrib/oid2name/oid2name.c
@@ -62,7 +62,7 @@ void		sql_exec_dumpalltbspc(PGconn *conn, struct options *opts);
 void
 get_opts(int argc, char **argv, struct options *my_opts)
 {
-	static struct option long_options[] = {
+	static const struct option long_options[] = {
 		{"dbname", required_argument, NULL, 'd'},
 		{"host", required_argument, NULL, 'h'},
 		{"host", required_argument, NULL, 'H'}, /* deprecated */
diff --git a/src/backend/access/transam/xlogprefetcher.c b/src/backend/access/transam/xlogprefetcher.c
@@ -362,7 +362,7 @@ XLogPrefetcher *
 XLogPrefetcherAllocate(XLogReaderState *reader)
 {
 	XLogPrefetcher *prefetcher;
-	static HASHCTL hash_table_ctl = {
+	const HASHCTL hash_table_ctl = {
 		.keysize = sizeof(RelFileLocator),
 		.entrysize = sizeof(XLogPrefetcherFilter)
 	};
diff --git a/src/common/sha1.c b/src/common/sha1.c
@@ -61,7 +61,7 @@
 #include "sha1_int.h"
 
 /* constant table */
-static uint32 _K[] = {0x5a827999, 0x6ed9eba1, 0x8f1bbcdc, 0xca62c1d6};
+static const uint32 _K[] = {0x5a827999, 0x6ed9eba1, 0x8f1bbcdc, 0xca62c1d6};
 
 #define K(t)	_K[(t) / 20]
 
diff --git a/src/pl/plpython/plpy_cursorobject.c b/src/pl/plpython/plpy_cursorobject.c
@@ -27,7 +27,7 @@ static PyObject *PLy_cursor_iternext(PyObject *self);
 static PyObject *PLy_cursor_fetch(PyObject *self, PyObject *args);
 static PyObject *PLy_cursor_close(PyObject *self, PyObject *unused);
 
-static char PLy_cursor_doc[] = "Wrapper around a PostgreSQL cursor";
+static const char PLy_cursor_doc[] = "Wrapper around a PostgreSQL cursor";
 
 static PyMethodDef PLy_cursor_methods[] = {
 	{"fetch", PLy_cursor_fetch, METH_VARARGS, NULL},

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ static const gbtree_ninfo tinfo =`
`113`	`113`	`Interval *`
`114`	`114`	`abs_interval(Interval *a)`
`115`	`115`	`{`
`116`		`- static Interval zero = {0, 0, 0};`
	`116`	`+ static const Interval zero = {0, 0, 0};`
`117`	`117`
`118`	`118`	`if (DatumGetBool(DirectFunctionCall2(interval_lt,`
`119`	`119`	`IntervalPGetDatum(a),`
Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ void sql_exec_dumpalltbspc(PGconn conn, struct options opts);`
`62`	`62`	`void`
`63`	`63`	`get_opts(int argc, char *argv, struct options my_opts)`
`64`	`64`	`{`
`65`		`- static struct option long_options[] = {`
	`65`	`+ static const struct option long_options[] = {`
`66`	`66`	`{"dbname", required_argument, NULL, 'd'},`
`67`	`67`	`{"host", required_argument, NULL, 'h'},`
`68`	`68`	`{"host", required_argument, NULL, 'H'}, /* deprecated */`
Original file line number	Diff line number	Diff line change
`@@ -362,7 +362,7 @@ XLogPrefetcher *`
`362`	`362`	`XLogPrefetcherAllocate(XLogReaderState *reader)`
`363`	`363`	`{`
`364`	`364`	`XLogPrefetcher *prefetcher;`
`365`		`- static HASHCTL hash_table_ctl = {`
	`365`	`+ const HASHCTL hash_table_ctl = {`
`366`	`366`	`.keysize = sizeof(RelFileLocator),`
`367`	`367`	`.entrysize = sizeof(XLogPrefetcherFilter)`
`368`	`368`	`};`